Skip to content

dict.get(), streamline setmode(), PEP8 isinstance() #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codenio merged 1 commit into from
Sep 29, 2025
Merged

dict.get(), streamline setmode(), PEP8 isinstance() #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 15 additions & 29 deletions Mock/GPIO.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,15 @@
import logging

logger = logging.getLogger(__name__)

log_level = os.getenv("LOG_LEVEL")

if log_level is not None:
if log_level.lower() == "info":
logger.setLevel(logging.INFO)
if log_level.lower() == "debug":
logger.setLevel(logging.DEBUG)
if log_level.lower() == "warning":
logger.setLevel(logging.WARNING)
if log_level.lower() == "error":
logger.setLevel(logging.ERROR)
if log_level.lower() == "critical":
logger.setLevel(logging.CRITICAL)
else:
logger.setLevel(logging.ERROR)

logger.setLevel(
{
"critical": logging.CRITICAL,
"debug": logging.DEBUG,
"error": logging.ERROR,
"info": logging.INFO,
"warning": logging.WARNING,
}.get(os.getenv("LOG_LEVEL", "error").lower(), logging.ERROR)
)
stream_formatter = logging.Formatter("%(asctime)s:%(levelname)s: %(message)s")
stream_handler = logging.StreamHandler()
stream_handler.setFormatter(stream_formatter)
Expand Down Expand Up @@ -84,17 +76,11 @@ def setmode(mode):
"""
global _mode
global setModeDone
# GPIO = GPIO()
global setModeDone
global _mode
if mode == BCM:
setModeDone = True
_mode = mode

elif mode == BOARD:
setModeDone = True
else:
setModeDone = False
setModeDone = mode == BOARD


def getmode():
Expand Down Expand Up @@ -123,7 +109,7 @@ def setup(channels, direction, initial=0, pull_up_down=PUD_OFF):
"""
global channel_config

if type(channels) is list or type(channels) is tuple:
if isinstance(channels, (list, tuple)):
for channel in channels:
logger.info(
"Setup channel : {} as {} with initial :{} and pull_up_down {}".format(
Expand All @@ -147,9 +133,9 @@ def output(channels, values):
values - 0/1 or False/True or LOW/HIGH

"""
if type(channels) is list or type(channels) is tuple:
if isinstance(channels, (list, tuple)):
for channel in channels:
if type(values) is list or type(values) is tuple:
if isinstance(values, (list, tuple)):
for value in values:
logger.info(
"Output channel : {} with value : {}".format(channel, value)
Expand All @@ -159,7 +145,7 @@ def output(channels, values):
"Output channel : {} with value : {}".format(channel, values)
)
else:
if type(values) is list or type(values) is tuple:
if isinstance(values, (list, tuple)):
for value in values:
logger.info(
"Output channel : {} with value : {}".format(channels, value)
Expand Down Expand Up @@ -317,7 +303,7 @@ def cleanup(channels=None):
[channels] - individual channel or list/tuple of channels to clean up. Default - clean every channel that has been used.
"""
if channels is not None:
if type(channels) is list or type(channels) is tuple:
if isinstance(channels, (list, tuple)):
for channel in channels:
logger.info("Cleaning up channel : {}".format(channel))
else:
Expand Down
Loading