fix(deps): update open package to resolve browser launch on KDE Plasma 6#242
Open
YatWoirat wants to merge 1 commit intocodemie-ai:mainfrom
Open
fix(deps): update open package to resolve browser launch on KDE Plasma 6#242YatWoirat wants to merge 1 commit intocodemie-ai:mainfrom
YatWoirat wants to merge 1 commit intocodemie-ai:mainfrom
Conversation
The open package in v8.4.2 relies on an outdated bundled xdg-open script that lacks a case for KDE_SESSION_VERSION=6, causing it to fail silently on KDE Plasma 6 during SSO authentication. Bumping to v10.2.0 updates the internal xdg-open utility to v1.2.1, which natively supports Plasma 6. This update also includes broader Linux compatibility fixes from the upstream package that may help with similar issues on other setups. Relates to codemie-ai#203 Relates to codemie-ai#205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
openpackage from v8.4.2 to v10.2.0 to resolve a silent failure during browser-based authentication flows on Linux with KDE Plasma 6.Motivation
When using
codemie setupwith the SSO provider on Linux with KDE Plasma 6, the browser failed to open, causing the setup process to hang and eventually timeout.This occurs because
open@8.4.2relies on an outdated bundledxdg-openscript that explicitly checks forKDE_SESSION_VERSION4 or 5. Since Plasma 6 sets this variable to 6, the switch statement had no match. The script executed nothing, exited with0(success), causing the silent failure.Changes
openfrom^8.4.2to^10.2.0inpackage.json.openv10 updates the internalxdg-openutility to v1.2.1, as well as includes other Linux/macOS fixes.Testing
npm run test:runlocally to ensure no tests are broken.codemie setuplocally on a KDE Plasma 6 Wayland system; verified the browser opens correctly.openv10.x is fully compatible with Node >= 20.0.0 and pure ESM.npm run ci:full.Related Issues
Relates to #203
Relates to #205