Skip to content

fix: crash in toggleViewsHints - debugDiv.appendChild (toolbar.js)#9735

Merged
paulbalandan merged 3 commits into
codeigniter4:developfrom
mjomble:fix-9727
Oct 3, 2025
Merged

fix: crash in toggleViewsHints - debugDiv.appendChild (toolbar.js)#9735
paulbalandan merged 3 commits into
codeigniter4:developfrom
mjomble:fix-9727

Conversation

@mjomble

@mjomble mjomble commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Description
Fixes #9727

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage (no tests for JS)
  • User guide updated
  • Conforms to style guide

@mergeable

mergeable Bot commented Oct 1, 2025

Copy link
Copy Markdown

Hi there, mjomble! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed this is working correctly.

Please add a changelog entry, see: https://github.com/codeigniter4/CodeIgniter4/pull/9736/files

@mjomble

mjomble commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

I noticed that both our PRs fix an Uncaught TypeError in toolbar.js, so I added a changelog line that refers to both bugs in plural.
When merging it all together, we can keep this one line instead of two very similar ones.

@mjomble mjomble changed the title fix: cash in toggleViewsHints - debugDiv.appendChild fix: cash in toggleViewsHints - debugDiv.appendChild (toolbar.js) Oct 3, 2025
@mjomble mjomble changed the title fix: cash in toggleViewsHints - debugDiv.appendChild (toolbar.js) fix: crash in toggleViewsHints - debugDiv.appendChild (toolbar.js) Oct 3, 2025
@michalsn

michalsn commented Oct 3, 2025

Copy link
Copy Markdown
Member

Fair enough. Thank you.

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 3, 2025
@paulbalandan paulbalandan merged commit 8544f6a into codeigniter4:develop Oct 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Crash in toggleViewsHints - debugDiv.appendChild

3 participants