Skip to content

refactor: do not use direct access and unset on $_COOKIE and $_POST #10353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulbalandan wants to merge 1 commit into
base: 4.8
Choose a base branch
from
+5 −32
Open

refactor: do not use direct access and unset on $_COOKIE and $_POST #10353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/system/Debug/ExceptionHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ public function testCopyErrorReportOmitsSensitiveRequestDataAndTraceArgs(): void
{
$exception = $this->createExceptionWithSensitiveTraceArgument();

$_COOKIE['debug_cookie'] = 'cookie-secret';
$_POST['debug_post'] = 'post-secret';
service('superglobals')
->setCookie('debug_cookie', 'cookie-secret')
->setPost('debug_post', 'post-secret');

try {
$report = $this->extractCopyableErrorReport($this->renderHtmlException($exception));
Expand All @@ -139,7 +140,7 @@ public function testCopyErrorReportOmitsSensitiveRequestDataAndTraceArgs(): void
$this->assertStringNotContainsString('$_COOKIE', $report);
$this->assertStringNotContainsString('$_POST', $report);
} finally {
unset($_COOKIE['debug_cookie'], $_POST['debug_post']);
service('superglobals')->unsetCookie('debug_cookie')->unsetPost('debug_post');
}
}

Expand Down
13 changes: 0 additions & 13 deletions utils/phpstan-baseline/codeigniter.superglobalsOffsetAssign.neon
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions utils/phpstan-baseline/codeigniter.superglobalsOffsetUnset.neon
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
# total 1799 errors
# total 1795 errors

includes:
- argument.type.neon
- arguments.count.neon
- assign.propertyType.neon
- codeigniter.modelArgumentType.neon
- codeigniter.superglobalsOffsetAssign.neon
- codeigniter.superglobalsOffsetUnset.neon
- deadCode.unreachable.neon
- empty.notAllowed.neon
- function.resultUnused.neon
Expand Down
Loading