refactor(database): optimize _processForeignKeys() string allocations and loop invariants#10351
Open
gr8man wants to merge 2 commits into
Open
refactor(database): optimize _processForeignKeys() string allocations and loop invariants#10351gr8man wants to merge 2 commits into
gr8man wants to merge 2 commits into
Conversation
Refactors _processForeignKeys() to: - calculate invariant SQL fragments outside the loop - cache escaped table identifier - build SQL string locally before concatenating to the array, saving intermediate string allocations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors
_processForeignKeys()inForge.phpto optimize performance and reduce memory allocations:fkSuffix,prefixSql) once outside the main loop.$this->db->escapeIdentifiers().sprintf()and string appending before performing a single concatenation to the$sqlsarray. This saves multiple intermediate array lookup and string allocations per foreign key.Checklist: