feat: add Query Builder lock wait modifiers#10349
Open
memleakd wants to merge 2 commits into
Open
Conversation
Add nowait() and skipLocked() for pessimistic SELECT locks. - Support driver-specific SQL generation for MySQLi, Postgre, OCI8, and SQLSRV. - Reject unsupported lock/wait combinations explicitly. - Preserve lock wait state across compiled selects, exists(), and countAllResults(). - Document driver support and SQLSRV READPAST behavior. - Add focused Query Builder tests for generated SQL, reset behavior, and unsupported combinations. Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
michalsn
reviewed
Jun 29, 2026
- Avoid incompatible SQLSRV table hints for lockForUpdate()->skipLocked() - Add live SQLSRV coverage for skip locked execution - Document pessimistic lock and wait modifier driver support - Clarify that existence/count probes do not apply locking modifiers Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
nowait()andskipLocked()methods to Query Builder for pessimisticSELECTlocks.They can be used together with
lockForUpdate()orsharedLock()to control what should happen when selected rows cannot be locked immediately.Example:
Unsupported combinations throw a
DatabaseException, the same way existing pessimistic lock limitations are handled.Supported combinations:
lockForUpdate()->nowait(): MySQLi, Postgre, OCI8, SQLSRVlockForUpdate()->skipLocked(): MySQLi, Postgre, OCI8, SQLSRVsharedLock()->nowait(): Postgre, SQLSRVsharedLock()->skipLocked(): PostgreSQLSRV uses table hints for this feature. For
skipLocked(), it usesREADCOMMITTEDLOCKandREADPAST, with the documented SQL Server limitation that some locks may still be waited on.Tests were added for generated SQL, unsupported combinations, reset behavior, and
exists()/countAllResults()handling.Checklist: