chore: sync all codefresh code changes into v2.14.9#388
Merged
Conversation
Change the branch condition from 'release-*' to 'sync-*' for setting the IMAGE_TAG based on the VERSION file. This aligns the script's behavior with the new branching strategy.
- Introduced CfOptions struct to encapsulate application versioning and Git client options for manifest generation. - Updated GenerateManifests function signature to accept CfOptions instead of individual parameters. - Adjusted related function calls and tests to align with the new structure, improving code readability and maintainability.
upstream later added `Namespace` which serves the same role.
the helm chart is now explicitly setting it to `false` anyway. so the default value was only used in e2e tests (and making them fail)
- Modify image tag format to include branch name and commit SHA. - Change repository references from 'argoproj/argo-cd' to 'codefresh-io/argo-cd'. - Adjust trigger conditions for release workflow to focus on branches.
ci - run on every pr into `sync-*` release - run on every push to `sync-*`
This reverts commit b35f04f.
ATGardner
changed the title
Remove commented-out branch checks and ensure IMAGE_TAG is set to the version from the VERSION file when not explicitly declared. This change improves consistency in manifest generation.
Update the image tag generation logic to replace slashes in the GitHub reference with underscores, ensuring consistent and valid tag formats for the image in the GitHub Container Registry.
Updated the image tag generation logic to clean the reference names by replacing slashes with underscores. This ensures a more consistent and predictable tagging format when pushing images to the registry.
the build-only OR build-and-push steps should run. not both.
…pr into them * every push to sync-* branch should trigger the image.yaml pipeline. it will build an image, tag it vx.y.a-yyyy-mm-ss-git_hash and push it to `quay.io/codefresh/argocd` * every push to a branch that has a pull request to sync-* should trigger the image.yaml pipeline. it will build an image, tag it vx.y.z-branch_name-git_sha and push it to `quay.io/codefresh/dev/argocd`
returned codecov run jobs
Ensure consistent formatting in the conditional statement for uploading test results to Codecov in the CI workflow. This change improves readability without altering functionality.
- Added spaces in the types list for pull_request to enhance readability. - Standardized comments for permissions in build-and-publish jobs.
Ensure proper formatting of quay_image_name by adding a missing '/' when the event is a pull request. This change improves the clarity and correctness of the image name used in the workflow.
Added a 1-second delay before the app sync operation in the TestGetVirtualProjectMatch test to prevent errors caused by sync window restrictions. This change ensures that the test runs smoothly without being blocked by the sync window.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sync-2.14.9 #388 +/- ##
==============================================
Coverage ? 53.92%
==============================================
Files ? 385
Lines ? 61206
Branches ? 0
==============================================
Hits ? 33006
Misses ? 25379
Partials ? 2821 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adjust the conditions for uploading test results to Codecov and executing the SonarQube scan to ensure they only run for the 'sync-*' branches, improving the accuracy of the CI process.
ATGardner
added a commit
that referenced
this pull request
Apr 20, 2025
squashed all of our code changes from `v2.13.3-2025.3.5-50344f005` into a single change over upstream `v2.14.9` --------- Co-authored-by: Vadim Gusev <ubuntolog@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: