Skip to content

⚡️ Speed up function extended_roboflow_errors_handler by 59% #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function extended_roboflow_errors_handler by 59% #790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions inference/core/workflows/execution_engine/v1/step_error_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,22 @@ def legacy_step_error_handler(step_name: str, error: Exception) -> None:


def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
if isinstance(
error,
(
ModelManagerLockAcquisitionError,
InferenceModelNotFound,
),
error_type = type(error)

if (
error_type is ModelManagerLockAcquisitionError
or error_type is InferenceModelNotFound
):
raise error
if isinstance(error, InvalidModelIDError):
elif error_type is InvalidModelIDError:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=400,
public_message=f"Problem with Workflow Block configuration - {error}",
context="workflow_execution | step_execution",
inner_error=error,
) from error
if isinstance(error, RoboflowAPINotAuthorizedError):
elif error_type is RoboflowAPINotAuthorizedError:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=401,
Expand All @@ -42,7 +41,7 @@ def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
context="workflow_execution | step_execution",
inner_error=error,
) from error
if isinstance(error, RoboflowAPIForbiddenError):
elif error_type is RoboflowAPIForbiddenError:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=403,
Expand All @@ -51,7 +50,7 @@ def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
context="workflow_execution | step_execution",
inner_error=error,
) from error
if isinstance(error, RoboflowAPINotNotFoundError):
elif error_type is RoboflowAPINotNotFoundError:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=404,
Expand All @@ -60,7 +59,7 @@ def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
context="workflow_execution | step_execution",
inner_error=error,
) from error
if isinstance(error, HTTPCallErrorError):
elif error_type is HTTPCallErrorError:
if error.status_code == 400:
raise ClientCausedStepExecutionError(
block_id=step_name,
Expand All @@ -70,7 +69,7 @@ def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
context="workflow_execution | step_execution",
inner_error=error,
) from error
if error.status_code == 401:
elif error.status_code == 401:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=401,
Expand All @@ -79,7 +78,7 @@ def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
context="workflow_execution | step_execution",
inner_error=error,
) from error
if error.status_code == 403:
elif error.status_code == 403:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=403,
Expand All @@ -88,7 +87,7 @@ def extended_roboflow_errors_handler(step_name: str, error: Exception) -> None:
context="workflow_execution | step_execution",
inner_error=error,
) from error
if error.status_code == 404:
elif error.status_code == 404:
raise ClientCausedStepExecutionError(
block_id=step_name,
status_code=404,
Expand Down
Loading