Skip to content

⚡️ Speed up method PropertyValueDict.__delitem__ by 25% #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method PropertyValueDict.__delitem__ by 25% #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/bokeh/core/property/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,16 +347,20 @@ class PropertyValueDict(PropertyValueContainer, dict[str, T_Val]):
x.update

"""

def __init__(self, *args, **kwargs) -> None:
super().__init__(*args, **kwargs)
# Directly call dict.__init__ for efficiency, then PropertyValueContainer.__init__
dict.__init__(self, *args, **kwargs)
PropertyValueContainer.__init__(self)

def _saved_copy(self):
return dict(self)

# delete x[y]
@notify_owner
def __delitem__(self, y):
return super().__delitem__(y)
# Avoid extra stack frames and unnecessary return by just calling dict.__delitem__
dict.__delitem__(self, y)

# x[i] = y
@notify_owner
Expand Down