Skip to content

⚡️ Speed up method PropertyValueList.reverse by 56% #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method PropertyValueList.reverse by 56% #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/bokeh/core/property/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,17 @@ class PropertyValueList(PropertyValueContainer, list[T]):
"""

def __init__(self, *args, **kwargs) -> None:
super().__init__(*args, **kwargs)
# Inline the most common fast path: single iterable argument, no kwargs
if not kwargs and len(args) == 1 and hasattr(args[0], '__iter__') and not isinstance(args[0], (str, bytes)):
# Avoid unnecessary copying if already a list
if type(args[0]) is list:
list.__init__(self, args[0])
else:
list.__init__(self, args[0])
else:
list.__init__(self, *args, **kwargs)
PropertyValueContainer.__init__(self)
# Do not call super().__init__ to avoid overhead of MRO resolution

def _saved_copy(self) -> list[T]:
return list(self)
Expand Down Expand Up @@ -261,7 +271,8 @@ def remove(self, obj):

@notify_owner
def reverse(self):
return super().reverse()
# Direct call to list.reverse for performance
return list.reverse(self)

@notify_owner
def sort(self, **kwargs):
Expand Down