Skip to content

⚡️ Speed up method FlexBox._check_empty_layout by 35% #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method FlexBox._check_empty_layout by 35% #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/bokeh/models/layouts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
from __future__ import annotations

import logging # isort:skip
from bokeh.core.has_props import abstract
from bokeh.core.validation import warning
from bokeh.core.validation.warnings import EMPTY_LAYOUT

log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -477,8 +481,7 @@ def __init__(self, *args, **kwargs) -> None:

@warning(EMPTY_LAYOUT)
def _check_empty_layout(self):
from itertools import chain
if not list(chain(self.children)):
if not self.children:
return str(self)

@warning(BOTH_CHILD_AND_ROOT)
Expand Down