Skip to content

⚡️ Speed up function make_globally_unique_css_safe_id by 51% #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function make_globally_unique_css_safe_id by 51% #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions src/bokeh/util/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
#-----------------------------------------------------------------------------
from __future__ import annotations

from bokeh.core.types import ID

import logging # isort:skip

log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -270,21 +273,23 @@ def make_id() -> ID:
return make_globally_unique_id()

def make_globally_unique_id() -> ID:
''' Return a globally unique UUID.
""" Return a globally unique UUID.


Some situations, e.g. id'ing dynamically created Divs in HTML documents,
always require globally unique IDs.

Returns:
str

'''
from ..core.types import ID
"""
# Removing the redundant import of ID from ..core.types since it is already imported above

return ID(str(uuid.uuid4()))

def make_globally_unique_css_safe_id() -> ID:
''' Return a globally unique CSS-safe UUID.
""" Return a globally unique CSS-safe UUID.


Some situations, e.g. id'ing dynamically created Divs in HTML documents,
always require globally unique IDs. ID generated with this function can
Expand All @@ -293,17 +298,21 @@ def make_globally_unique_css_safe_id() -> ID:
Returns:
str

'''
from ..core.types import ID
"""
# Removing the redundant import of ID from ..core.types since it is already imported above


max_iter = 100

for _i in range(0, max_iter):
id = make_globally_unique_id()
if id[0].isalpha():
return id
# Optimization: inline uuid generation and checking, avoiding make_globally_unique_id
# Indirectly calling str(uuid.uuid4()) saves function call overhead for up to 100 iterations
for _ in range(max_iter):
uid = str(uuid.uuid4())
if uid[0].isalpha():
return ID(uid)

return ID(f"bk-{make_globally_unique_id()}")
# Fallback, as before: prefix with 'bk-'
return ID(f"bk-{str(uuid.uuid4())}")

def array_encoding_disabled(array: npt.NDArray[Any]) -> bool:
''' Determine whether an array may be binary encoded.
Expand Down