Skip to content

deps: drop the RUSTSEC-2026-0459 ignore once sqlx accepts libsqlite3-sys 0.39 #98

Open

Description

@codecapo

The chore pull request of 2026-11-09 adds an ignore for RUSTSEC-2026-0459 (CVE-2026-119375) to deny.toml. SQLite before 3.54 can return uninitialised page-cache memory when a database is opened next to a crafted -wal file whose page size differs. The bundled copy in libsqlite3-sys 0.30.1 is SQLite 3.46.0, and it reaches the tree through sqlx-sqlite 0.8.6 and sqlx 0.8, which iceberg-catalog-sql requires (cargo tree -i libsqlite3-sys). The fix is libsqlite3-sys 0.39, which bundles SQLite 3.54. No sqlx release accepts it: sqlx-sqlite 0.9.0 caps libsqlite3-sys below 0.38, and iceberg-rust main still requires sqlx 0.8.1. Only catalog.db in the warehouse directory is opened through this SQLite, and Infostash is the only writer there, so the exposure is a crafted file placed next to the catalog by someone else.

crates/storage declares sqlx only to turn on the SQLite driver of the copy iceberg-catalog-sql uses (crates/storage/Cargo.toml). Bumping that declaration to another major version, as dependabot proposes in #71, builds a second sqlx and leaves the catalog's copy without a driver, which is why the tests in #71 fail with a pool panic. Keep the declaration on the version iceberg-rust uses, and let dependabot skip sqlx majors until iceberg-rust moves.

Done when

  • A sqlx release accepts libsqlite3-sys >= 0.39 and iceberg-rust pins it; Cargo.toml and crates/storage/Cargo.toml move together.
  • cargo tree -i libsqlite3-sys shows only versions at or above 0.39.
  • The ignore and its comment are removed from deny.toml, and cargo deny check passes.

Points: 1

Depends on: upstream sqlx and iceberg-rust releases
Blocks: nothing

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/storagecrates/storageblockedWaiting on another issue or a decisiondependenciesPull requests that update a dependency file

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions