You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The design review of 2026-11-01 touches this issue. The quick start's last step, infoctl query "select * from gold.daily_revenue" (README.md:42 at a0b5e6c), shows one row per day only once ready/daily_revenue is rebuilt in full on every run, so that step waits for the @full_refresh directive (#90), while the rest of the quick start can be built and tested first as an append-only slice.
Suggested additions to the Done-when:
Once compiler: implement the @full_refresh directive #90 lands, the CSV file added before the second infoctl run holds a second order, with its own order_id, for a day that already has one (for example 100, then 20 for 2026-10-29), and the test asserts that the README.md:42 query returns one row per day, with revenue 120 for that day. Appending the delta would instead give (2026-10-29, 100) and (2026-10-29, 20) side by side, because an incremental read returns only the new commit's rows (crates/storage/tests/iceberg_roundtrip.rs:77-79).
The quick start's text (README.md:36-43) agrees with the narrowed statement about incremental runs that docs: fix README, architecture and ROADMAP statements the code does not back #94 makes at README.md:23 and ROADMAP.md:13: where it shows gold.daily_revenue, it says that this table is rebuilt on every run, as @full_refresh means (docs/rfcs/0001-project-files.md:121), so the second run is not described as processing only new rows in every table.
Source: design review of 2026-11-01, finding C02 (with the worked example in section 2.1), section 8.3 (the candidate milestone) and section 8.5 (D1 and M5).
Activity
codecapo commentedon Nov 6, 2026
The design review of 2026-11-01 touches this issue. The quick start's last step,
infoctl query "select * from gold.daily_revenue"(README.md:42at a0b5e6c), shows one row per day only onceready/daily_revenueis rebuilt in full on every run, so that step waits for the@full_refreshdirective (#90), while the rest of the quick start can be built and tested first as an append-only slice.Suggested additions to the Done-when:
infoctl runholds a second order, with its ownorder_id, for a day that already has one (for example 100, then 20 for 2026-10-29), and the test asserts that theREADME.md:42query returns one row per day, with revenue 120 for that day. Appending the delta would instead give (2026-10-29, 100) and (2026-10-29, 20) side by side, because an incremental read returns only the new commit's rows (crates/storage/tests/iceberg_roundtrip.rs:77-79).infoctl queryreads the Clean table instead ofgold.daily_revenue, as does the test that checks its output. That slice needs only thefast_appendcommits that both write paths incrates/storagealready make (crates/storage/src/lib.rs:143-148,:205-211), as long as the Clean model has no@unique_key. The RFC 0001 example has one (docs/rfcs/0001-project-files.md:89), but merging on it is Merge rows on @unique_key #35, which the quick start does not wait for, so the quick start needs a Clean model without it, before compiler: implement the @full_refresh directive #90 and after. Whatinfoctl initwrites stays with infoctl init: create an example project #8.README.md:36-43) agrees with the narrowed statement about incremental runs that docs: fix README, architecture and ROADMAP statements the code does not back #94 makes atREADME.md:23andROADMAP.md:13: where it showsgold.daily_revenue, it says that this table is rebuilt on every run, as@full_refreshmeans (docs/rfcs/0001-project-files.md:121), so the second run is not described as processing only new rows in every table.Work that moved to new tickets:
@full_refresh, soready/daily_revenuereplaces its table on every run and keeps one row per day.ready/daily_revenue.sqlexample (docs/rfcs/0001-project-files.md:101-107) carries-- @full_refresh: trueand each kind of model has a defined output.Source: design review of 2026-11-01, finding C02 (with the worked example in section 2.1), section 8.3 (the candidate milestone) and section 8.5 (D1 and M5).