fix: prevent StreamWriter from disposing HttpResponse.Body in ConfigurableResponseNegotiator#4
Merged
gimlichael merged 2 commits intov1.0.0/initialfrom Mar 1, 2026
Conversation
Merged
…se.Body Co-authored-by: gimlichael <8550919+gimlichael@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update pull request based on review feedback
fix: prevent StreamWriter from disposing HttpResponse.Body in ConfigurableResponseNegotiator
Mar 1, 2026
There was a problem hiding this comment.
Pull request overview
Prevents ConfigurableResponseNegotiator from accidentally closing HttpResponse.Body by ensuring the StreamWriter does not dispose the underlying response stream, avoiding corruption of the ASP.NET Core response pipeline.
Changes:
- Construct
StreamWriterwithleaveOpen: truewhen writing toHttpResponse.Body.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamWriterconstructed directly overHttpResponse.Bodydisposes the underlying response stream when the writer is disposed, which can corrupt the ASP.NET Core response pipeline.Change
Added
leaveOpen: trueto theStreamWriterconstructor, withbufferSize: -1to preserve the default buffer size:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.