Skip to content

Fix NullReferenceException in ConfigurableResponseNegotiator when Accept-Charset header is absent #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gimlichael merged 2 commits into from
Mar 1, 2026
Merged

Fix NullReferenceException in ConfigurableResponseNegotiator when Accept-Charset header is absent #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b6236
Initial plan
Copilot Mar 1, 2026
98a134d
fix: add null-conditional operator to prevent NullReferenceException …
Copilot Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Codebelt.Extensions.Carter/Response/ConfigurableResponseNegotiator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public virtual bool CanHandle(MediaTypeHeaderValue accept)
public virtual Encoding GetEncoding(HttpRequest request)
{
var acceptCharset = request.GetTypedHeaders().AcceptCharset;
if (acceptCharset.Count > 0)
if (acceptCharset?.Count > 0)
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acceptCharset?.Count > 0 produces a nullable boolean (because ?.Count is int?), which cannot be used directly as an if condition. This will fail to compile. Use a non-nullable condition (e.g., coalesce the count to 0, compare to true, or use a property pattern like checking acceptCharset is { Count: > 0 }).

Suggested change
if (acceptCharset?.Count > 0)
if (acceptCharset is { Count: > 0 })

Copilot uses AI. Check for mistakes.
Comment on lines 70 to +71
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a unit test for the reported scenario (no Accept-Charset header) to ensure GetEncoding returns the default encoding and does not throw. There are already GetEncoding_* tests in the test project, but none cover the missing-header case.

Copilot uses AI. Check for mistakes.
{
var preferred = acceptCharset
.OrderByDescending(x => x.Quality ?? 1.0)
Expand Down