Repository navigation
perf: get_health_summary uses one query instead of 4 per source - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29.
get_health_summary() previously ran 4 separate queries per source (last_run, last_success, error_count, total_runs) — 4N+1 total for N sources. Reworked to fetch every SyncLog row once (ordered newest-first) and aggregate per source in Python — O(1) queries regardless of source count.
Also closed a real coverage gap found while touching this file: there was no test_health.py at all before this. Added 8 tests covering empty-DB, single/multiple sources, error counting, and specifically that last_success correctly reflects an earlier success even when the most recent run failed (the reason last_success is tracked separately from last_run in the first place).
Verified: 64/64 tests pass (56 existing + 8 new); smoke-tested tendertracker health end-to-end, output unchanged from before the refactor.