Repository navigation
feat: fix forward after a failed rollback instead of a pause that needs root - #47
Merged
Merged
Conversation
…ds root Fixes #34 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After an apply fails and its rollback fails too, the instance is now broken instead of paused:
pullgate status NAME --resume.Reason:line. Inautomode the owner is asked too.healthends the broken state. One that fails gets no rollback: the state stays broken, and the next newer commit is asked.allow_older). Root checks the rule again at the tap.pullgate statusshowsbroken: since …, last error: …. Root's--resumeends it. Nothing from Telegram can end it. A pause file still stops everything.DESIGN.md sections 10, 12 and 13, THREAT-MODEL.md T6, the README and the security reviewer checklist describe it.
Tests
internal/gate/broken_test.go:TestFailedRollbackIsBroken,TestBrokenFixForward,TestBrokenBadFixForwardStaysBroken,TestBrokenRefusesNonDescendant,TestBrokenAsksInAutoMode,TestRootResumeEndsBroken,TestBrokenDropsOlderQuestions,TestBrokenTapRefusesNonFixForward(failed commit, other commit, auto question).Reviews
The security reviewer and a correctness review ran. Fixed: old questions survived the failure, an auto question could apply, the warning lost the apply error, the
--resumetext, the save-failure path, a fixed warning line, the reviewer checklist. Not done: tests for a failed save and a cut-off during a fix forward (both use the paths that exist and are tested today:in_progressstays and the next start pauses).Fixes #34
🤖 Generated with Claude Code