fix(coding-agent): settle aborting retrying goal turns#59
Merged
Conversation
…etry # Conflicts: # packages/coding-agent/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes abort handling for active goal continuations after retry/error states. The retry abort controller is now ready before
auto_retry_startis emitted, so an immediate Esc/session abort can cancel the retry sleep instead of leaving the UI in a working state.Changes
auto_retry_start.abortedorerror.agent_endand an e2e retry-abort goal turn.Verification
npx tsx ../../node_modules/vitest/dist/cli.js --run test/suite/goal-e2e.test.ts test/suite/goal-extension.test.ts test/suite/goal-modules.test.ts test/suite/agent-session-queue.test.ts test/suite/agent-session-retry-events.test.tsEvidence:
local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/focused-tests.txtnpm run checkEvidence:
local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/npm-run-check-final.txtnode .agents/skills/senpi-qa/scripts/lib/common.mjs --self-checknode .agents/skills/senpi-qa/scripts/rpc-drive.mjs --self-testnode .agents/skills/senpi-qa/scripts/mock-loop.mjs --self-testnode .agents/skills/senpi-qa/scripts/tui-smoke.mjs --self-testEvidence:
local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/manual-qa-matrix.mdReview
Summary by cubic
Fixes immediate Esc cancellation during auto-retry and stops goal auto-continues after terminal turns, including when tool execution is aborted.
Bug Fixes
auto_retry_start, so Esc cancels the retry sleep immediately.agent_endonly when the last assistant turn ended cleanly; do not continue afteraborted,error, or aborted tool results.Refactors
command-registration.ts.tool-registration.ts.Written for commit c94307e. Summary will update on new commits.