Skip to content

fix(coding-agent): settle aborting retrying goal turns#59

Merged
code-yeongyu merged 6 commits into
mainfrom
fix/abort-esc-after-retry
Jun 21, 2026
Merged

fix(coding-agent): settle aborting retrying goal turns#59
code-yeongyu merged 6 commits into
mainfrom
fix/abort-esc-after-retry

Conversation

@code-yeongyu

@code-yeongyu code-yeongyu commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes abort handling for active goal continuations after retry/error states. The retry abort controller is now ready before auto_retry_start is emitted, so an immediate Esc/session abort can cancel the retry sleep instead of leaving the UI in a working state.

Changes

  • Create retry abort controller before publishing auto_retry_start.
  • Stop active goal continuation from queuing another hidden follow-up when the last assistant turn ended as aborted or error.
  • Split goal command/tool registration out of the large goal extension module.
  • Add focused regressions for aborted/error goal agent_end and an e2e retry-abort goal turn.

Verification

  • npx tsx ../../node_modules/vitest/dist/cli.js --run test/suite/goal-e2e.test.ts test/suite/goal-extension.test.ts test/suite/goal-modules.test.ts test/suite/agent-session-queue.test.ts test/suite/agent-session-retry-events.test.ts
    Evidence: local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/focused-tests.txt
  • npm run check
    Evidence: local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/npm-run-check-final.txt
  • senpi QA common/RPC/mock-loop/TUI:
    • node .agents/skills/senpi-qa/scripts/lib/common.mjs --self-check
    • node .agents/skills/senpi-qa/scripts/rpc-drive.mjs --self-test
    • node .agents/skills/senpi-qa/scripts/mock-loop.mjs --self-test
    • node .agents/skills/senpi-qa/scripts/tui-smoke.mjs --self-test
      Evidence: local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/
  • Manual QA matrix: local-ignore/qa-evidence/20260621-abort-esc-after-retry-refresh/manual-qa-matrix.md

Review

  • review-work QA: PASS
  • review-work code quality: PASS
  • review-work security: PASS
  • review-work context mining: PASS

Summary by cubic

Fixes immediate Esc cancellation during auto-retry and stops goal auto-continues after terminal turns, including when tool execution is aborted.

  • Bug Fixes

    • Initialize the retry abort controller before emitting auto_retry_start, so Esc cancels the retry sleep immediately.
    • Queue a goal continuation after agent_end only when the last assistant turn ended cleanly; do not continue after aborted, error, or aborted tool results.
  • Refactors

    • Moved goal command registration to command-registration.ts.
    • Moved goal tool registration to tool-registration.ts.

Written for commit c94307e. Summary will update on new commits.

Review in cubic

@code-yeongyu code-yeongyu merged commit 7dcfd14 into main Jun 21, 2026
3 checks passed
@code-yeongyu code-yeongyu deleted the fix/abort-esc-after-retry branch June 21, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant