fix: prevent arithmetic overflow crash#97
Open
raulriera wants to merge 3 commits intorefactor-new-serverfrom
Open
fix: prevent arithmetic overflow crash#97raulriera wants to merge 3 commits intorefactor-new-serverfrom
raulriera wants to merge 3 commits intorefactor-new-serverfrom
Conversation
raulriera
commented
Feb 13, 2026
| var canDismissSheet: Bool = false | ||
|
|
||
| private var fee: ExchangedFiat { | ||
| var fee: ExchangedFiat { |
Collaborator
Author
There was a problem hiding this comment.
This was preventing the tests from running (I really need to start running the tests in Xcode Cloud)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the safety and correctness of currency calculations and comparisons, particularly for high-rate currencies that could previously cause UInt64 overflows. The changes introduce overflow checks, safer comparison logic, and comprehensive tests to ensure robust handling of large values and different decimal precisions.