[Rebrand] Move Music Lab theme boundary to root#73730
Draft
ebeastlake wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #73649 for Sanchit's review comment about
data-theme="Dark"living lower in the tree.This moves the Music Lab dark design-system theme boundary to the Music Lab root (
#music-lab) and removes the now-redundant local boundaries from:No token, color, layout, or behavior changes intended. This is the small architectural follow-up to Hannah's #73300 note: Music Lab did not have a root DS dark theme yet, so earlier rebrand work added local boundaries where needed.
Testing story
Static checks run:
./tools/hooks/pre-commityarn run typecheckfromapps/rg -n 'data-theme="Dark"|data-theme=\x27Dark\x27' apps/src/musicshows onlyapps/src/music/views/MusicLabView.tsxLocal dashboard was not running on
localhost:9000orlocalhost:3000when I made this follow-up, so I could not take a Playwright screenshot from this environment.Hey, human. Add screenshots here before marking ready:
Before screenshot
After screenshot
Manual pass to do on a running dashboard:
DCDO.set('brand-router-enabled', true)and test?brand=codeai-nextso the pink audit still covers all surfaces from [Rebrand] MusicLab -> Design System #73300 plus PackDialog.