[fix] Restore plugin script global aliases - #892
Open
sekiroxxxx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Older PinK versions persisted
simulateGlobals: truewhen users cleared theplugin script “Simulate Globals” field. That metadata remains in existing
projects. cocos-cli later treats the value as an alias array during plugin
script import, causing the reimport to fail.
Custom aliases also replaced the default
self,window,global, andglobalThisaliases instead of extending them.Root cause
The JavaScript importer only supplied default aliases when
simulateGlobalswas
undefined. It neither normalized persisted values at the importerboundary nor merged valid custom aliases with the default aliases.
Changes
and duplicate aliases.
Impact
This only changes alias resolution for enclosed plugin scripts:
Test plan
simulateGlobals: true; the importshould succeed with the default aliases.
custom aliases should be available.
should contain each alias once.
Verification
git diff --checkpass.generated
src/i18n/types/generateddirectory, which is unrelated to thischange.