fix(preview): keep material mesh visible after inspector apply - #885
Open
looopmax wants to merge 1 commit into
Open
fix(preview): keep material mesh visible after inspector apply#885looopmax wants to merge 1 commit into
looopmax wants to merge 1 commit into
Conversation
bofeng-song
approved these changes
Aug 25, 2026
Inspector dumps encode an unset pass phase as an empty string.
Applying that override made getPhaseID('') register a unique unused
render phase, so the preview mesh disappeared. Drop empty phase
overrides before rebuilding passes.
Co-authored-by: Cursor <cursoragent@cursor.com>
looopmax
force-pushed
the
fix/material-preview-empty-phase
branch
from
August 25, 2026 11:04
7afa5bc to
5fca023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phaseoverrides before material preview rebuilds passes.Cause
Material inspector dumps encode an unset effect pass phase as
''.Pass.fillPipelineInfotreats any defined phase as an override, andgetPhaseID('')registers a unique unused render phase. After Apply, the preview camera still draws the default phase, so the mesh disappears.Verification
npx jest src/core/scene/test/material-preview-states.test.tsnpx tsc -b --pretty falsenpm run build:static-web