Repository navigation
build: drop the boot image's duplicate kernel mirror and its unused rustfmt/clippy download - #456
Merged
Merged
Conversation
…ustfmt/clippy download cdn.kernel.org serves the tarballs again and is KERNEL_MIRROR's default, so the chain tried it twice; the init build fetched rustfmt and clippy from the toolchain file on every uncached build and used neither.
CMGS
added a commit
that referenced
this pull request
Nov 5, 2026
…cargo already does, and the image version defaults silkd builds with the pinned toolchain minus rustfmt, clippy and the toolchain file's x86_64 target, as boot/init does since #456; the release profile strips, so the Dockerfile and release workflow no longer strip again. boot, base and android take their version args from the Makefile and CI only, so a bare build fails loudly instead of building from a stale pin. PATCHES becomes PATCHES.md, which the image hash already skips.
CMGS
added a commit
that referenced
this pull request
Nov 5, 2026
…cargo already does, and the image version defaults silkd builds with the pinned toolchain minus rustfmt, clippy and the toolchain file's x86_64 target, as boot/init does since #456; the release profile strips, so the Dockerfile and release workflow no longer strip again. boot, base and android take their version args from the Makefile and CI only, so a bare build fails loudly instead of building from a stale pin. PATCHES becomes PATCHES.md, which the image hash already skips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups in
boot/Dockerfilethat the post-#447 audit found (#455 listed them as a decision because they rebuild the image).v6.x/linux-6.18.37.tar.xz, checked today), and sinceKERNEL_MIRRORdefaults to cdn the loop tried it twice. The hard-coded cdn entry is gone and the comment states the chain as it is:KERNEL_MIRROR, kernel.org's edge mirror, the rsync mirror. The SHA256 check is unchanged.init/rust-toolchain.tomllistsrustfmtandclippy, which the rust base image does not carry, so every uncached build synced the channel and downloaded both components and used neither. The build now drops thecomponentsline from its copy of the file; the file still pins the compiler, and local development and CI keep both components.Evidence
docker build --no-cache --target initbuild boot(linux/arm64): the old Dockerfile logsinfo: syncing channel updates,info: latest update on 2026-10-15 for version 1.99.1andinfo: downloading 2 components; the new one logs no rustup network step, andsandbox-initbuilds in 3.4 s.kernel/SHA256: the default mirror fetches and verifies (/tmp/linux.tar.xz: OK); with a first mirror that answers 404 it falls through to the edge mirror and verifies.Cost
Merging to
mainmatches theimagesworkflow'sboot/**path filter, so it rebuilds the boot carrier on both native runners and then the os-images that base on it. The kernel and initramfs contents are unchanged.silkd/Dockerfilehas the same toolchain-component pattern; it is left alone here because changing it rebuilds silkd and every guest image too.