Repository navigation
review: the audit's final tidy: layout, docs, shared test helpers - #432
Merged
Merged
Conversation
…d no restated helpers
… error lists, collapse duplicated pages
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last step of the audit that #420, #422, #424, #425, #426, #427, #428, #429, #430 and #431 came from. It fixes no bug and changes one error message. It makes the tree they leave consistent.
This branch is built by path from the tree that was verified, not by replaying its 96 commits, because #427's later commits overlap most of them. The final tree is byte-identical to the verified one (
git rev-parse HEAD^{tree}matches95500f19).Production code
No change in behaviour, apart from the message below.
pool.trip, and two messages sayinspectwhere they saidlist.leaseWindowreplaces three copies ofleaseTTL - leaseMargin.dropPoolbecomesdropPoolLocked.VolumeCallTimeoutbecomes an unexportedsyncTimeout, because no other package reads it.TakeOwnedsharescollect. The peer fan-out useshttp.DefaultClient, since every call already has a context deadline.writableMountsbecomesslices.ContainsFunc. The env row rewrite callsputRowdirectly.ErrArchivedsaid "an exec or file call wakes it first", which is wrong for a pool with areader. It now says "a wake or an exec wakes it first".Hot path: none. Nothing here runs on the claim path except moved declarations.
Docs
kernel.pty.maxcaps a node at about 4057 VMs, because each VM holds a console pty.Tests
CloseRelaysmust end a conn with EOF rather than at the conn's own deadline, and a hole-only scan checks every chunk.hibernateClaim,mustAdopt,waitWarm,newTestEngine,statusOfandstoretest.StageRecord.Evidence
Run on the same tree as this branch, on macOS and in Linux containers, with the PostgreSQL suites against a real server:
TestCloneFileRemovesFailedDestinationfails only on the container's overlay filesystem. It failed the same way in earlier runs of this audit, and it was not rerun onmainfor comparison.41 mutants ran on darwin: 40 killed, and the 1 survivor was expected to pass. They did not run on Linux.
Hardware results are in the PR bodies of the fixes they cover. The two-node failover and high-density round ran before the last test cleanups. The last hardware run, a warm pool of 0 recovering after a rollback, was one docs commit before this tree.
sdk/openaiandsdk/langchaintests did not run.