Repository navigation
test, docs: drop duplicate volume tests and the failover runbook - #402
Merged
Merged
Conversation
Remove tests whose behavior another test already pins (claim-time writable plus live add, the detach-result write stage covered by the two-restart test, the reader-under-writer admission row, the direct capture refusals) and fold fork and the no-engine-call check into the capture test. The archive-failover runbook existed to explain the removed replica refusal; keep its one constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup after the volume rounds; no production code changes.
Docs:
deploy.md"Disabling archive failover" was a four-step runbook added by #383 to explain the replica refusal that #398 removed. It keeps the one constraint that still matters: replicas and archive rows retire only through the registry, so drain them with failover on before turning it off.Tests (each removed check is pinned elsewhere):
TestLiveAttachPreservesWritableAndAttachOnlyVolumes: the four-mode test adds a writer and an attach-only writer live and refuses their shape changes.TestLiveVolumePersistenceFailureRetainsRecoverableState:TestLiveDetachResultWriteFailureSurvivesTwoRestartscovers the same failed write in more depth; the table loses its per-stage branches.TestAdmitClaimExcludesReaderUnderWriter: the "writer excludes reader" row ofTestVolumeAdmissionMatrix.TestVolumeClaimRejectsDirectCapture: the "applied" case ofTestVolumeHoldsRejectCaptureBeforeTrim, which now also checks fork and that no capture reaches the engine.TestClaimVolumeCompatibilityExpansionrows that repeattypes.ValidateVolumescases; it keeps the legacy expansion rows.Net: test −94, docs −27.
Gates: golangci-lint
0 issues.(sandboxd, linux and darwin), fmt clean, asl unchanged,go test -race ./pool/ ./server/.