Repository navigation
pool: runtime volume catalog follow-ups to #382 - #395
Merged
Merged
Conversation
…oval forgetClaim dropped a running claim without its holds, so ownership transfer left them counted after the VM was gone. Carry the holds into the VM removal, the same way reap and release do.
ErrVolumeCatalogUnavailable maps to 503 with Retry-After, but a marshal failure repeats on every retry. Return the wrapped error so it surfaces as a server error.
Register and load ran the same roots check after normalizing. Move it into normalize and let startup load write straight into the catalog, since a failed load discards the manager.
The failed-write test compared two missing names once the pending design was gone. The two archived-hold tests repeated the same recovery setup, and the admission bench rebuilt writeVolumeImage by hand.
The catalog file is always 0600, PUT also returns 409 for a held name, and changes leave an op:volumes audit record. Drop statements repeated across deploy, api and live-volumes docs, and restore the converging sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #382.
DELETE /v1/volumes/{name}until restart.forgetClaimnow hands the holds to the VM removal, as reap and release do. Regression test:TestOwnershipTransferReleasesRunningVolumeHoldAfterRemovalfails without the fix.Retry-After, but it repeats on every retry. It now returns a plain wrapped error.volume_rootscheck moves into catalog normalization, so register and startup load share one path. Startup load writes straight into the catalog.op:"volumes"audit record. Statements repeated across deploy, API and live-volumes docs are dropped.Net: prod -1, test -2, docs -6. No change on the claim path.
Gates:
go test -race ./...in sandboxd (19 packages ok); golangci-lint v2.13.20 issues.for sandboxd and e2e on linux and darwin; fmt clean; asl reports only the five forwarders main already has.