Repository navigation
fix(os-image): image checks fail when they should, picoclaw is pinned - #305
Merged
Merged
Conversation
set -e ignores a negated command, so every '! cmd' in verify-vm-inner.sh passed whatever it found, including an unresolved scrcpy-rfb library or an X server left in the image. They now fail the build. Drop the check that named an internal DNS prefix. Pin picoclaw to v0.3.1 with a sha256 like every other downloaded binary, and stop printing the first twelve characters of the API key. Remove two validate-image assertions that compared a value to itself, and number start.sh's steps correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes held back from #304, because merging any
os-image/**change rebuilds and publishes images.Changes
verify-vm-inner.sh:set -eignores a negated command, so every! cmdpassed whatever it found. Those checks now fail the build: nofuse-overlayfs, no unresolvedscrcpy-rfblibrary, no X server, noscrcpy. The check naming an internal DNS prefix is removed.24.04-picoclaw/Dockerfile: pin picoclaw to v0.3.1 with a sha256 instead ofreleases/latest.picoclaw-init: print only the last four characters of the API key, and fix ruff F541.validate-image.sh: remove two assertions that compared a value to itself or repeated an earlier fatal check.start.sh: step labels read[1/7] [4/7] [5/7] [7/7]; they are now[1/4]to[4/4].prepare-gapps16-inner.sh: comments no longer say x86_64 about ABI-agnostic paths.What merging does
The workflow rebuilds every tag of a family when any file under it changes. This rebuilds and publishes all
ubuntutags and alldebiantags.androidis untouched on purpose: its only item was a comment. Merge when a rebuild is wanted.Risk: the first effective run of these checks is the redroid image build
latestresolves to, to v0.3.1, which islatesttoday.Verified
bash -non the edited scripts; shellcheck SC2251 count forverify-vm-inner.shis now 0.refutepasses on an absent command, and fails with status 1 on a present command and on an unresolved library line.ruff check --select Fpasses onpicoclaw-init, and the file parses.picoclaw. The arm64 digest comes from the release metadata and was not downloaded.Not changed
start.shstill downloads CH v51.0, below the v54 floorcocoon-checkenforces. It starts CH directly without cocoon, and a bump was not tested.