Repository navigation
fix: an unparsable COCOON_MACOS_LOG_LEVEL prints its error before the exit - #54
Merged
Merged
Conversation
… exit SetupLog fails before the global logger exists, so Fatalf went through a disabled logger and the CLI exited 1 with no output.
…log to stderr itself
…and vm inspect say hostfwd=tcp::N-:22 bound every host interface, so a --ssh-port VM with the image's fixed login was reachable from the network. VNC already binds 127.0.0.1.
…variables, list the e2e REAL-tier tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COCOON_MACOS_LOG_LEVELnow prints its error before exiting.SetupLogfails before the global logger exists, so the CLI exited 1 with no output.hostfwd=tcp::N-:22bound every host interface, so a--ssh-portVM, whose image ships a fixed login, was reachable from the network. The docs andvm inspectboth givelocalhost:N, and VNC already binds 127.0.0.1.setupLogdrops the stdout swap, because core v0.1.5 already writes the log to stderr.[REAL]tier listsqemu-system-x86_64andsocat.Evidence
macOS,
COCOON_MACOS_LOG_LEVEL=verbose cocoon-macos version:rc=1, no output.rc=1,setup log: Unknown Level String: 'verbose', defaulting to NoLevel.QEMU 10.0.13 on a Linux testbed, one paused VM per form, the listener read with
ssand probed over TCP:hostfwdtcp::42298-:22(main)0.0.0.0:42298tcp:127.0.0.1:42299-:22(this branch)127.0.0.1:42299Gates at
16a2b6b:make fmt-checkandmake linton darwin and linux: 0 issues.go test -race ./...: pass.aslon darwin and linux: clean.Size: prod +4/-7, tests +1/-1, docs +5/-5.