Skip to content

fix: an unparsable COCOON_MACOS_LOG_LEVEL prints its error before the exit - #54

Merged
CMGS merged 4 commits into
masterfrom
review/round-2026-09-25
Sep 26, 2026
Merged

CMGS merged 4 commits into
masterfrom
review/round-2026-09-25

Conversation

@CMGS

@CMGS CMGS commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • fix: an unparsable COCOON_MACOS_LOG_LEVEL now prints its error before exiting. SetupLog fails before the global logger exists, so the CLI exited 1 with no output.
  • fix: the user-mode SSH forward listens on loopback only. hostfwd=tcp::N-:22 bound every host interface, so a --ssh-port VM, whose image ships a fixed login, was reachable from the network. The docs and vm inspect both give localhost:N, and VNC already binds 127.0.0.1.
  • review: setupLog drops the stdout swap, because core v0.1.5 already writes the log to stderr.
  • docs: the GPU note links to known-issues, the workflow (not the build script) derives the image variables, and the e2e [REAL] tier lists qemu-system-x86_64 and socat.

Evidence

macOS, COCOON_MACOS_LOG_LEVEL=verbose cocoon-macos version:

  • main: rc=1, no output.
  • this branch: rc=1, setup log: Unknown Level String: 'verbose', defaulting to NoLevel.

QEMU 10.0.13 on a Linux testbed, one paused VM per form, the listener read with ss and probed over TCP:

hostfwd listens on from 127.0.0.1 from the host's address
tcp::42298-:22 (main) 0.0.0.0:42298 accepts accepts
tcp:127.0.0.1:42299-:22 (this branch) 127.0.0.1:42299 accepts refuses

Gates at 16a2b6b:

  • make fmt-check and make lint on darwin and linux: 0 issues.
  • go test -race ./...: pass.
  • asl on darwin and linux: clean.

Size: prod +4/-7, tests +1/-1, docs +5/-5.

… exit

SetupLog fails before the global logger exists, so Fatalf went through a disabled logger and the CLI exited 1 with no output.
…and vm inspect say

hostfwd=tcp::N-:22 bound every host interface, so a --ssh-port VM with the image's fixed login was reachable from the network. VNC already binds 127.0.0.1.
@CMGS
CMGS merged commit f6e616c into master Sep 26, 2026
3 checks passed
@CMGS
CMGS deleted the review/round-2026-09-25 branch September 26, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant