Repository navigation
Remove telemetry - #161
Merged
Merged
Remove telemetry#161
Conversation
rafiss
force-pushed
the
rafiss/telemetry-on-first-connect
branch
from
September 30, 2026 03:22
34a29f0 to
907ab5e
Compare
rafiss
force-pushed
the
rafiss/telemetry-on-first-connect
branch
from
September 30, 2026 04:26
907ab5e to
1b7684b
Compare
rafiss
added this pull request to stack #163
September 30, 2026 04:35
rafiss
marked this pull request as ready for review
September 30, 2026 04:35
rafiss
removed this pull request from stack #163
September 30, 2026 04:36
rafiss
force-pushed
the
rafiss/telemetry-on-first-connect
branch
from
September 30, 2026 05:11
1b7684b to
94dc52f
Compare
rafiss
changed the title
rafiss
force-pushed
the
rafiss/telemetry-on-first-connect
branch
from
September 30, 2026 05:16
94dc52f to
3d5a28f
Compare
Previously, the Sequelize and sequelize-cockroachdb versions were recorded with crdb_internal.increment_feature_counter from an afterInit hook, which runs as soon as a Sequelize instance is constructed. That made Sequelize open a connection even if the application never used the instance, and logged a "Could not record telemetry" error when no database was reachable (e.g. in unit tests). The telemetry queries were also logged through the application's logger. Stop sending telemetry since this data is no longer required. The cockroachdbTelemetryDisabled dialect option is still accepted, but no longer has any effect. This also re-enables two Sequelize integration tests that failed because the telemetry queries were logged through the application's logger. Fixes #155. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rafiss
force-pushed
the
rafiss/telemetry-on-first-connect
branch
from
September 30, 2026 05:19
3d5a28f to
7d22a41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Sequelize and sequelize-cockroachdb versions were
recorded with crdb_internal.increment_feature_counter from an afterInit
hook, which runs as soon as a Sequelize instance is constructed. That
made Sequelize open a connection even if the application never used the
instance, and logged a "Could not record telemetry" error when no
database was reachable (e.g. in unit tests). The telemetry queries were
also logged through the application's logger.
Stop sending telemetry since this data is no longer required. The
cockroachdbTelemetryDisabled dialect option is still accepted, but no
longer has any effect.
This also re-enables two Sequelize integration tests that failed
because the telemetry queries were logged through the application's
logger.
Fixes #155.
🤖 Generated with Claude Code