[CRDB-53890] helm: setup the infra on the openshift to run single and multi region tests#607
Open
shreyaskm623 wants to merge 1 commit intomasterfrom
Open
[CRDB-53890] helm: setup the infra on the openshift to run single and multi region tests#607shreyaskm623 wants to merge 1 commit intomasterfrom
shreyaskm623 wants to merge 1 commit intomasterfrom
Conversation
shreyaskm623
changed the title
shreyaskm623
changed the title
shreyaskm623
changed the title
shreyaskm623
force-pushed
the
shreyaskm/openshfit-advanced-e2e
branch
2 times, most recently
from
2c22c43 to
f9a78e9
Compare
There was a problem hiding this comment.
Pull request overview
Adds OpenShift as a supported provider in the operator e2e test framework, aiming to run the single-region and multi-region operator test suites on OpenShift clusters provisioned on GCP via openshift-install.
Changes:
- Introduces an
openshiftinfra provider (OpenShiftRegion) and wires it into provider selection/factory. - Adds OpenShift-specific e2e behaviors (SCC bindings, Helm uninstall flags, storage class / cluster domain overrides, cleanup hardening).
- Adjusts operator installation to allow overriding
cloudRegionto satisfy operator webhook validation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testutil/cert-manager.go | Makes bundle cleanup more defensive (ignore missing file/resources). |
| tests/e2e/operator/singleRegion/cockroachdb_single_region_e2e_test.go | Adds OpenShift provider option and improves cleanup for OpenShift constraints. |
| tests/e2e/operator/region.go | Adds OpenShift-specific install/cleanup logic and operator install cloudRegion override support. |
| tests/e2e/operator/multiRegion/cockroachdb_multi_region_e2e_test.go | Adds OpenShift provider option for multi-region suite. |
| tests/e2e/operator/infra/common.go | Registers ProviderOpenShift and its region codes/annotations defaults. |
| tests/e2e/operator/infra/provider.go | Extends ProviderFactory to construct OpenShiftRegion. |
| tests/e2e/operator/infra/openshift.go | New provider implementation using openshift-install, kubeconfig merge, DNS operator patching, and teardown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds OpenShift as a supported cloud provider in the operator e2e infra framework so the existing single-region and multi-region operator Helm test suites can run against OpenShift clusters provisioned on GCP via openshift-install.
Changes:
- Add a new
openshiftinfra provider (provisioning/reuse, VPC peering, CoreDNS, DNS operator patching, autoscaler, Submariner for multi-region). - Update operator tests and chart install/cleanup flow to support OpenShift specifics (SCC bindings, hook handling, storage class, region/provider semantics).
- Adjust e2e cleanup utilities and increase multi-region test timeout.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testutil/cert-manager.go | Makes bundle deletion best-effort and avoids failing cleanup when the manifest file is missing. |
| tests/e2e/operator/singleRegion/cockroachdb_single_region_e2e_test.go | Adds openshift provider option and OpenShift-specific cleanup; currently disables infra teardown. |
| tests/e2e/operator/region.go | Adds OpenShift SCC bindings, OpenShift Helm/delete behavior adjustments, and operator cloudRegion override support. |
| tests/e2e/operator/multiRegion/cockroachdb_multi_region_e2e_test.go | Adds openshift provider option for multi-region runs. |
| tests/e2e/operator/infra/provider.go | Wires ProviderOpenShift into the provider factory. |
| tests/e2e/operator/infra/openshift.go | New OpenShift infra implementation (install/reuse, peering, CoreDNS, DNS, autoscaler, Submariner, kubeconfig merge). |
| tests/e2e/operator/infra/common.go | Adds ProviderOpenShift and OpenShift-specific CoreDNS internal service support. |
| tests/e2e/coredns/coredns.go | Adds a ClusterIP CoreDNS service for UDP+TCP/53 and extends cluster option struct. |
| Makefile | Increases multi-region test timeout from 60m to 300m. |
| broker-info.subm | Adds a Submariner broker info artifact (contains credentials). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shreyaskm623
force-pushed
the
shreyaskm/openshfit-advanced-e2e
branch
from
753da54 to
3c38699
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shreyaskm623
force-pushed
the
shreyaskm/openshfit-advanced-e2e
branch
from
3c38699 to
ed2ee7f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shreyaskm623
force-pushed
the
shreyaskm/openshfit-advanced-e2e
branch
from
ed2ee7f to
d8ac9f0
Compare
… operator tests Adds OpenShift as a supported cloud provider in the e2e operator test framework, enabling the full operator test suite to run on OpenShift clusters provisioned on GCP via openshift-install, for both single-region and multi-region setups.
shreyaskm623
force-pushed
the
shreyaskm/openshfit-advanced-e2e
branch
from
d8ac9f0 to
a8bf0b7
Compare
shreyaskm623
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OpenShift as a supported cloud provider in the e2e operator test framework,
enabling the full operator test suite to run on OpenShift clusters provisioned
on GCP via
openshift-install, for both single-region and multi-region setups.JIRA: https://cockroachlabs.atlassian.net/browse/CRDB-53890
TODO:
defaultOpenShiftProjectIDfrom"cockroach-shreyaskm"to"helm-testing"inopenshift.goto match the GCP provider default and avoid accidental provisioning into a personal project whenGCP_PROJECT_IDis unset.