Add VMServiceScrape configuration for CockroachDB monitoring#579
Open
cuisongliu wants to merge 2 commits intocockroachdb:masterfrom
Open
Add VMServiceScrape configuration for CockroachDB monitoring#579cuisongliu wants to merge 2 commits intocockroachdb:masterfrom
cuisongliu wants to merge 2 commits intocockroachdb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for VictoriaMetrics monitoring by introducing
VMServiceScraperesources and corresponding configuration options, alongside improvements to the existing PrometheusServiceMonitorsetup. The main changes include new Helm templates for VictoriaMetrics, configuration options invalues.yaml, and the addition of service monitoring for the optional Visus component.VictoriaMetrics monitoring support:
vmServiceScrape.yamlto generateVMServiceScraperesources for VictoriaMetrics Operator, enabling metrics scraping from CockroachDB and the optional Visus service. This includes support for custom labels, annotations, intervals, namespace scoping, and TLS configuration.vmServiceScrapeconfiguration section invalues.yamlto control the VictoriaMetrics monitoring feature, with options for enabling, labeling, annotating, and configuring scrape intervals and TLS.Prometheus ServiceMonitor improvements:
serviceMonitor.yamltemplate to add aServiceMonitorfor the Visus component when enabled, mirroring the main CockroachDB monitoring setup.serviceMonitor.yamlfor Visus endpoints by correcting the conditional logic and indentation, ensuring proper rendering when TLS is enabled and Visus is not in insecure mode.