Skip to content

Provide ability to specify certificate key size #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alleny87 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Provide ability to specify certificate key size #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85d41aa
Provide ability to specify key size
alleny87 Jun 29, 2022
4a0ecc7
Update certificate.node.yaml
alleny87 Jun 29, 2022
e298ec5
Update values.yaml
alleny87 Jun 29, 2022
4fe25f3
Merge pull request #1 from alleny87/patch-3
alleny87 Jun 29, 2022
cfc1a01
Merge pull request #2 from alleny87/patch-4
alleny87 Jun 29, 2022
52c5147
Merge pull request #3 from alleny87/patch-2
alleny87 Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cockroachdb/templates/certificate.client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ spec:
{{- if .Values.tls.certs.useCertManagerV1CRDs }}
privateKey:
algorithm: RSA
size: 2048
size: {{ .Values.tls.certs.certDetails.keySize }}
{{- else }}
keySize: 2048
keySize: {{ .Values.tls.certs.certDetails.keySize }}
keyAlgorithm: rsa
{{- end }}
commonName: root
Expand Down
4 changes: 2 additions & 2 deletions cockroachdb/templates/certificate.node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ spec:
{{- if .Values.tls.certs.useCertManagerV1CRDs }}
privateKey:
algorithm: RSA
size: 2048
size: {{ .Values.tls.certs.certDetails.keySize }}
{{- else }}
keySize: 2048
keySize: {{ .Values.tls.certs.certDetails.keySize }}
keyAlgorithm: rsa
{{- end }}
commonName: node
Expand Down
4 changes: 4 additions & 0 deletions cockroachdb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,10 @@ tls:
# Enable if the secret is a dedicated TLS.
# TLS secrets are created by cert-mananger, for example.
tlsSecret: false
# Fine Grain Cert details
certDetails:
# Certificate Key Size
keySize: 2048
# Enable if the you want cockroach db to create its own certificates
selfSigner:
# If set, the cockroach db will generate its own certificates
Expand Down