Repository navigation
use base 10 to parse integers - #63
Merged
Merged
Conversation
The new parsing code passes base 0 to strconv which causes it to interpret leading 0 as indicating an octal number. This is not what we want; in particular Pebble has a lot of tests which use file numbers with leading 0s.
RaduBerinde
force-pushed
the
parse-base-10
branch
from
November 23, 2025 01:28
68a7163 to
e134c1d
Compare
tbg
approved these changes
Nov 23, 2025
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new parsing code passes base 0 to strconv which causes it to interpret leading 0 as indicating an octal number. This is not what we want; in particular Pebble has a lot of tests which use file numbers with leading 0s.
This change is