fix 10s logging data race - #60
Merged
Merged
Conversation
The goroutine that logs every 10 seconds can race with the function exiting, which can lead to a data race or even a panic because of t.Log used after the test exits. The fix is to block until the goroutine is exiting, by writing to the unbuffered channel instead of closing it.
kev-cao
approved these changes
Oct 6, 2025
kev-cao
left a comment
kev-cao
left a comment
There was a problem hiding this comment.
LGTM! Thanks for getting the fix out
Member
Author
|
TFTR! |
craig Bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Oct 7, 2025
![craig[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
154867: go.mod: bump datadriven r=RaduBerinde a=RaduBerinde Bump datadriven to incorporate a fix (cockroachdb/datadriven#60). Epic: none Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goroutine that logs every 10 seconds can race with the function exiting, which can lead to a data race or even a panic because of t.Log used after the test exits.
The fix is to block until the goroutine is exiting, by writing to the unbuffered channel instead of closing it.
I reproduced and verified the fix, but it required temporary code changes and the test is too slow to check in.
This change is