Open
Conversation
fwiesel
force-pushed
the
extend-tests
branch
from
d1063a9 to
01400fd
Compare
Add test for - GetAggregates API failure scenario - AddToAggregate failure scenario - RemoveFromAggregate failure scenario - error condition when status doesn't change
- Group tests into 'Happy Path', 'Guard Conditions', and 'Failure Modes' - Add JustBeforeEach for automatic Reconcile execution in success paths - Extract sharedErrorConditionChecks function for DRY validation Verified that coverage remains unchanged
Added test for - lifecycle not enabled - maintenance not set to termination - GetHypervisor failure - hypervisor with running VMs - GetAggregates failure - RemoveFromAggregate failure - DeleteService failure - GetResourceProvider failure - CleanupResourceProvider failure Fixed typo in aggregate list (note-test -> node-test)
fwiesel
force-pushed
the
extend-tests
branch
from
01400fd to
acf6b02
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
- Group tests into 'Happy Path', 'Guard Conditions', and 'Failure Modes' - Extract sharedDecommissioningErrorCheck function for DRY validation - Move common setup to shared BeforeEach in Failure Modes
Added test for - hypervisor not existing (IgnoreNotFound behavior) - lifecycle not enabled - node terminating and offboarded (disableInstanceHA path) Fixed DeferCleanup to use IgnoreNotFound for deleted hypervisors
Add test for - non-existent hypervisor (not found case) - no-changes scenario (early return path)
Added test for - node lookup with NotFound (IgnoreNotFound behavior) - node with internal IP address
Added test for - non-existent hypervisor (IgnoreNotFound) - hypervisor still onboarding (early return) - empty ServiceID (skip compute service)
Add test for - node with various address types (DNS, IPs) - node without hypervisor label - non-existent node (not found case) - address handling and empty address filtering
- Separate 'API validation' from 'Reconciliation' tests - Group reconciliation tests into 'Happy Path' and 'Failure Modes' - Move shared hypervisor setup to outer BeforeEach - Improve test descriptions with clearer context naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.