Skip to content

Ad4mConnect with hosting and Unyt payment#559

Open
lucksus wants to merge 6 commits intodevfrom
feat/hosting
Open

Ad4mConnect with hosting and Unyt payment#559
lucksus wants to merge 6 commits intodevfrom
feat/hosting

Conversation

@lucksus
Copy link
Copy Markdown
Member

@lucksus lucksus commented Mar 18, 2026

Summary by CodeRabbit

  • Chores
    • Adjusted client hosting configuration to a new hosting mode for improved initialization behavior.
    • Updated and pinned several internal libraries to a newer compatible release to ensure stability and alignment with the hosting change.

depends on d9011e34-8219-4ba1-bdd1-7d104a25cd1f/91215135-9143-46eb-8f5d-b38504a40392#477

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 18, 2026

Deploy Preview for fluxsocial-dev ready!

Name Link
🔨 Latest commit 825012c
🔍 Latest deploy log https://app.netlify.com/projects/fluxsocial-dev/deploys/69cc31a247f15300082e68ff
😎 Deploy Preview https://deploy-preview-559--fluxsocial-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 035cae13-c1d1-4baf-911e-aa0de0f7ca3a

📥 Commits

Reviewing files that changed from the base of the PR and between a888573 and 03b5889.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

📝 Walkthrough

Walkthrough

Replaced Ad4m client option multiUser: true with hosting: true in the app initialization and updated Yarn resolutions to pin several @coasys/* Ad4m-related packages to 0.13.0-test-1.

Changes

Cohort / File(s) Summary
Ad4m Client Configuration
app/src/app.ts
Replaced multiUser: true with hosting: true in the getAd4mClient call; surrounding init/error handling unchanged.
Package Dependencies (resolutions)
package.json
Updated Yarn resolutions to pin @coasys/ad4m, @coasys/ad4m-connect, @coasys/ad4m-vue-hooks, @coasys/ad4m-react-hooks, and @coasys/hooks-helpers from 0.12.0 to 0.13.0-test-1. No other fields or scripts changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰
I hopped into configs, gentle and keen,
Swapped multiUser for hosting — a tidy scene.
Packages nudged forward, versions in tow,
A soft little change, now onward we go. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions 'hosting' which aligns with the main change in app.ts (replacing multiUser with hosting), but omits the package version upgrades that are also part of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/hosting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

53-53: Clarify the purpose of adding @preact/preset-vite.

The addition of @preact/preset-vite to resolutions appears unrelated to the PR's stated objective (Ad4mConnect with hosting and Unyt payment). If this is required for the hosting feature or a related dependency, consider documenting the rationale in the PR description.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 53, The package.json addition of "@preact/preset-vite"
in the resolutions section is unclear and may be unrelated to the PR goal;
update the PR description or commit message to explain why "@preact/preset-vite"
was added (e.g., required by hosting feature, transitive dependency fix, or
compatibility with Unyt payment integration) and reference the exact package
name "@preact/preset-vite" and the "resolutions" entry so reviewers can verify
necessity; if it's not required, remove the resolutions entry for
"@preact/preset-vite" from package.json and run dependency install to confirm no
breakage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@package.json`:
- Line 53: The package.json addition of "@preact/preset-vite" in the resolutions
section is unclear and may be unrelated to the PR goal; update the PR
description or commit message to explain why "@preact/preset-vite" was added
(e.g., required by hosting feature, transitive dependency fix, or compatibility
with Unyt payment integration) and reference the exact package name
"@preact/preset-vite" and the "resolutions" entry so reviewers can verify
necessity; if it's not required, remove the resolutions entry for
"@preact/preset-vite" from package.json and run dependency install to confirm no
breakage.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 09c1fc2e-6ea1-49ac-b7a3-49f11dc5a0d0

📥 Commits

Reviewing files that changed from the base of the PR and between ec273b5 and a888573.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • app/src/app.ts
  • package.json

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for flux-hot-hosting ready!

Name Link
🔨 Latest commit 825012c
🔍 Latest deploy log https://app.netlify.com/projects/flux-hot-hosting/deploys/69cc31a29320cf0008cad5f2
😎 Deploy Preview https://deploy-preview-559--flux-hot-hosting.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant