Repository navigation
test(runtime): pin the Dockerfile's node major and single digest to action.yml's runs.using - #690
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…ction.yml's runs.using runtime.test.ts already holds engines, devEngines, @types/node, the README, the contributing guide and every setup-node step to the major of runs.using, and dependabot.yml ignores the Dockerfile's node major with the note that it is bumped together with action.yml. The Dockerfile itself was the one pinned-together reference no test read: a FROM node:26-slim on either stage, or two stages on different digests, rendered and shipped silently. Both now fail the suite. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Reviewed by Reviewer notesRead the tree at head Verified:
One observation, not a defect: No findings. A maintainer can take this at face value; the only open question is the repo's usual hold/needs-kind labeling, which is process, not code. |
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Test Improvement
__tests__/runtime.test.ts— one newdescribeinside the existingaction.yml runs the bundle under node24block; no other file changes.runtime.test.tsalready holdsengines.node,devEngines.runtime,@types/node, the README,docs/contributing.mdand everysetup-nodestep to the major ofaction.yml'sruns.using, and its own comment says every other Node version in the repository must name the same major..github/dependabot.ymlignores the Dockerfile'snodemajor with the note that it is bumped together withaction.yml. The Dockerfile — the runtime the server and the chart's CronJob actually run on — was the one pinned-together reference no test read, so aFROM node:26-slimon either stage, or the two stages drifting to different digests, rendered and shipped silently.The new cases:
FROMlines namenode:<runs.using major>-slim@sha256:<64 hex>;Verified red-before-green by hand: a
node:26-slimruntime stage fails two cases (major + digest), a digest-only drift fails one;npx vitest run __tests__/runtime.test.tsatmain@9aa12b8passes 19/19;eslintandtsc -p tsconfig.test.jsonclean.Disjoint from held #680–#689: none of them touch
runtime.test.tsor the Dockerfile.Related Issue
None — the finding is fully resolved by this diff, so no tracking issue was opened.
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1