Skip to content

test(lgtm): pin that a reviewer's /lgtm on an issue whose author account is gone is applied #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hivecommons-hive wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

test(lgtm): pin that a reviewer's /lgtm on an issue whose author account is gone is applied #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions __tests__/label/lgtmGuards.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,27 @@ describe('/lgtm guards', () => {
expect(debug).toHaveBeenCalledWith('could not find lgtm to remove')
await expect(observeRemove.notCalled()).resolves.toBe('not called')
})

// the webhook schema allows `issue.user: null` (a deleted account); a reviewer's /lgtm on
// such an issue is nobody's own and is applied, not refused or failed on reading the author
it('a /lgtm by a reviewer on an issue whose author account is gone is applied', async () => {
const payload = structuredClone(issueCommentEvent)
payload.comment.body = '/lgtm'
Object.assign(payload.issue, { user: null })
const observeLabel = new utils.ObserveRequest()
const observeComment = new utils.ObserveRequest()
server.use(
http.get(`${utils.api}/orgs/Codertocat/members/Codertocat`, utils.mockResponse(204)),
http.get(`${utils.api}/repos/Codertocat/Hello-World/collaborators/Codertocat`, utils.mockResponse(404)),
http.get(`${utils.api}/repos/Codertocat/Hello-World/contents/OWNERS`, utils.mockResponse(404)),
utils.repoHasLabels(['lgtm']),
http.post(`${issue}/labels`, utils.mockResponse(200, null, observeLabel)),
http.post(`${issue}/comments`, utils.mockResponse(200, null, observeComment)),
)

await expect(lgtm(new utils.MockContext(payload))).resolves.toBeUndefined()

expect(await observeLabel.body()).toEqual({ labels: ['lgtm'] })
await expect(observeComment.notCalled()).resolves.toBe('not called')
})
})
Loading