Repository navigation
test: stop asserting the candidate order in the sweep warn-once bundle test - #637
Merged
mrbobbytables merged 1 commit intoOct 31, 2026
Merged
Conversation
…e test The sweep evaluates its candidates concurrently, so which pull request's queue read fails first, and which merge PUT lands first, varies from run to run. The test already said as much in its own comment but still pinned the warning to pr cncf#1 and the merge PUTs to [1, 2]. The new shuffle job caught it on the first main dispatch (run 41154250262): the warning named pr #2. Match the warning against either candidate and compare the merge PUTs sorted. The behaviour under test (one warning for the run, both candidates merged directly) is asserted exactly as before. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
mrbobbytables
force-pushed
the
test/merge-queue-warn-once-order
branch
from
October 31, 2026 01:20
a87c58e to
121ec5e
Compare
Contributor
|
Please add a kind label with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first dispatch of
test.ymlon main after #635 (run 41154250262) passedbuild-test,mutation(first live run of the nightly config, score above the 95 break),e2e-coverageandchart, butshufflefailed in__tests__/bundle/mergeQueueWarnOnce.test.ts:The sweep evaluates its candidates concurrently, so which candidate's queue read fails first (and so is the one named in the once-per-run warning) and which merge
PUTlands first are both races. The test's own comment already says the two tails "interleave in no fixed order", but two assertions still pinned the order. This is not seed-dependent; running the suite twice per pull request just doubles the chance of hitting it.This matches the warning against either candidate and compares the merge
PUTs sorted. The behaviour under test is unchanged: exactly one warning for the run, no enqueue, both candidates merged directly.No tracking issue; the failure is in the linked run and the fix is a two-line assertion change.
Testing
Modified
__tests__/bundle/mergeQueueWarnOnce.test.tsonly.npx eslint __tests__/bundle/mergeQueueWarnOnce.test.ts— passednpx vitest run __tests__/bundle/mergeQueueWarnOnce.test.ts×5 — passed each timenpm run lint— passed (one pre-existingjsdoc/check-param-nameswarning insrc/issueComment/cc.ts, also present on main)npm run typecheck— passedChecklist
npm run allto lint and build my code — ranlint,typecheckand the changed test directly instead; nosrc/ordist/change, sobuild/packare not affected and CI's dist-drift gate covers thatnpm run packand committeddist/— not applicable: test-only change,dist/untouched