Skip to content

test(hold): pin cancelHold's case fold on the issue's labels and on hold.label (Hold, DO-NOT-MERGE/HOLD) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbobbytables merged 1 commit into from
Oct 21, 2026
Merged

test(hold): pin cancelHold's case fold on the issue's labels and on hold.label (Hold, DO-NOT-MERGE/HOLD) #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions __tests__/label/hold.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,41 @@ describe('hold', () => {
await expect(observeLegacy.notCalled()).resolves.toBe('not called')
})

it('removes a mixed-case Hold and DO-NOT-MERGE/HOLD under their own names: label names fold case', async () => {
issueCommentEvent.comment.body = '/hold cancel'
const commentContext = new utils.MockContext(issueCommentEvent)

server.use(http.get(issueUrl, utils.mockResponse(200, issueWithLabels('Hold', 'DO-NOT-MERGE/HOLD'))))
const observeNew = observeDelete('DO-NOT-MERGE/HOLD')
const observeLegacy = observeDelete('Hold')

const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})
await handleIssueComment(commentContext)
await expect(observeNew.called()).resolves.toBe('called')
await expect(observeLegacy.called()).resolves.toBe('called')
expect(setFailed).not.toHaveBeenCalled()
})

it('removes the label under its own name when the configured hold.label differs from it only by case', async () => {
issueCommentEvent.comment.body = '/hold cancel'
const commentContext = new utils.MockContext(issueCommentEvent)

const file = structuredClone(labelFileContents)
file.content = Buffer.from('hold:\n label: Do-Not-Merge/Hold\n').toString('base64')
server.use(
http.get(utils.contentsUrl('.github/prow.yaml'), utils.mockResponse(200, file)),
http.get(issueUrl, utils.mockResponse(200, issueWithLabels('do-not-merge/hold'))),
)
const observeLower = observeDelete('do-not-merge/hold')
const observeConfigured = observeDelete('Do-Not-Merge/Hold')

const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})
await handleIssueComment(commentContext)
await expect(observeLower.called()).resolves.toBe('called')
await expect(observeConfigured.notCalled()).resolves.toBe('not called')
expect(setFailed).not.toHaveBeenCalled()
})

it('removes the configured hold.label and the legacy hold label once when they are the same', async () => {
issueCommentEvent.comment.body = '/hold cancel'
const commentContext = new utils.MockContext(issueCommentEvent)
Expand Down
Loading