Skip to content

test(trigger): pin /test's case-insensitive name and path match, the OK-To-Test label already present, and the green non-PR arm of /test and /ok-to-test #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbobbytables merged 1 commit into from
Oct 21, 2026
Merged

test(trigger): pin /test's case-insensitive name and path match, the OK-To-Test label already present, and the green non-PR arm of /test and /ok-to-test #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 53 additions & 3 deletions __tests__/issueCommentTest/trigger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,26 @@ describe('/test', () => {
expect(reruns).toEqual([1])
})

it.each([
['/test e2e', 'the display name', { id: 3, name: 'E2E', path: '.github/workflows/end-to-end.yml' }],
['/test lint-checks', 'the file basename', { id: 6, name: 'Lint', path: '.github/workflows/Lint-Checks.yml' }],
])('%s matches %s case-insensitively when the other does not match at all', async (body, _, spec) => {
const reruns: number[] = []
const reply = new utils.ObserveRequest()
server.use(
...memberAuth(),
serveRuns([{ ...spec, status: 'completed', conclusion: 'success' }]),
serveRerun(reruns),
http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)),
http.post(reactionUrl, utils.mockResponse(201, {})),
)

await handleIssueComment(new utils.MockContext(prCommentEvent(body)))

expect(reruns).toEqual([spec.id])
await expect(reply.notCalled()).resolves.toBe('not called')
})

it('matches a display name that differs from the file name by either', async () => {
const reruns: number[] = []
server.use(
Expand Down Expand Up @@ -633,16 +653,19 @@ describe('/test', () => {
expect((await reply.body()).body).toBe('The GitHub Actions workflow runs on `headsha` are already being re-run.')
})

it('on an issue comments that it only applies to pull requests', async () => {
it('on an issue comments that it only applies to pull requests and leaves the run green', async () => {
const reply = new utils.ObserveRequest()
const event = structuredClone(issueCommentEvent)
event.comment.body = '/test all'
server.use(http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)))
const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})

await handleIssueComment(new utils.MockContext(event))

await expect(reply.called()).resolves.toBe('called')
expect((await reply.body()).body).toBe('`/test` only applies to pull requests.')
expect(calls).toEqual(['POST /repos/Codertocat/Hello-World/issues/1/comments'])
expect(setFailed).not.toHaveBeenCalled()
})

it('refuses an outsider', async () => {
Expand Down Expand Up @@ -746,6 +769,29 @@ describe('/ok-to-test', () => {
expect(setFailed).not.toHaveBeenCalled()
})

it('recognises the label already present in another case: no re-add, the no-runs comment instead of a reaction', async () => {
const reaction = new utils.ObserveRequest()
const reply = new utils.ObserveRequest()
const label = new utils.ObserveRequest()
server.use(
...memberAuth(),
serveRuns([{ id: 2, name: 'Docs', status: 'completed', conclusion: 'success' }]),
http.get(`${repo}/issues/1`, utils.mockResponse(200, { labels: [{ name: 'OK-To-Test' }] })),
http.post(`${repo}/issues/1/labels`, utils.mockResponse(200, [], label)),
http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)),
http.post(reactionUrl, utils.mockResponse(201, {}, reaction)),
)
const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})

await handleIssueComment(new utils.MockContext(prCommentEvent('/ok-to-test')))

await expect(reply.called()).resolves.toBe('called')
expect((await reply.body()).body).toBe('No workflow runs waiting for approval on `headsha`.')
await expect(reaction.notCalled()).resolves.toBe('not called')
await expect(label.notCalled()).resolves.toBe('not called')
expect(setFailed).not.toHaveBeenCalled()
})

it('is refused for the pull request author', async () => {
const reply = new utils.ObserveRequest()
const runs = new utils.ObserveRequest()
Expand Down Expand Up @@ -820,16 +866,20 @@ describe('/ok-to-test', () => {
.toThrow('could not approve run 8 (CI): nope')
})

it('on an issue comments that it only applies to pull requests', async () => {
it('on an issue comments that it only applies to pull requests and leaves the run green', async () => {
const reply = new utils.ObserveRequest()
const runs = new utils.ObserveRequest()
const event = structuredClone(issueCommentEvent)
event.comment.body = '/ok-to-test'
server.use(http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)))
server.use(serveRuns(pendingRuns, runs), http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)))
const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})

await handleIssueComment(new utils.MockContext(event))

await expect(reply.called()).resolves.toBe('called')
expect((await reply.body()).body).toBe('`/ok-to-test` only applies to pull requests.')
await expect(runs.notCalled()).resolves.toBe('not called')
expect(setFailed).not.toHaveBeenCalled()
})
})

Expand Down
Loading