Repository navigation
test(bundle): drive tide's draft/files folds and sweep's labels fold through dist/index.js - #498
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…through dist/index.js tide.ts:258 (compare without files), tide.ts:426 (pull without draft) and sweep.ts:141 (listing without labels) were only reached by the unit suite; one bundle file now serves each optional field absent and asserts the fold. Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
Contributor
|
Please add a kind label with |
This was referenced Oct 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Files/functions claimed:
__tests__/bundle/tideOptionalFields.test.ts(new, test-only). Targetssrc/plugins/tide.tsexplainForkWorkflows(line 258,compared.data.files ?? []),src/plugins/tide.tsgetPull(line 426,data.draft ?? false) andsrc/cronJobs/sweep.tsapproveIfTrusted(line 141,pr.labels ?? []). No production code changes. Disjoint from #497 (approve.ts/meow.ts).Three bundle cases, each serving the optional REST field absent and driving
dist/index.js:pull_requestlabeled lgtm whoseGET /pulls/1has nodraft: treated as ready, squash-merged, nonot mergeable (draft).files: nothing counted behind, the warning and comment name only the pull request's own workflow file, full request sequence asserted.labels:::debug::sweep: #1 does not carry ok-to-test, noactions/runsread or approval, the rest of the sweep (blunderbuss review request) still runs.Verification (local, this branch, main @ 1062ce7)
npx eslint __tests__/bundle/tideOptionalFields.test.tscleannpm run test:coverage:e2e: 79 files / 490 tests pass (was 78 / 487); Branches 97.96% → 98.14% (1633 → 1636 / 1667);coverage-e2e/lcov.infono longer listsBRDA:258orBRDA:426underSF:src/plugins/tide.tsnorBRDA:141underSF:src/cronJobs/sweep.tsnpm run test:coveragealready covered all three)Related Issue
Refs #466 — this lands the folded tide/sweep optional-field finding (comment
hive-finding-foldedon #466); the remaining #466 items (approve.ts 228/230/415, meow.ts 88 dead arms) ship in #497, which closes it.Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88