[ROOT6]Updated root to tip of branch master#10684
Closed
akritkbehera wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
please test |
Contributor
|
A new Pull Request was created by @akritkbehera for branch IB/CMSSW_20_1_X/rootmaster. @akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
Contributor
|
cms-bot internal usage |
Contributor
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6587d0/54367/summary.html Failed External BuildI found compilation error when building: + echo 'test $?PY3_NUMPY_ROOT != 0 || source /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/py3-numpy/1.26.4-6c7401133d71aa0fdd19f4799dadfbdf/etc/profile.d/init.csh'
+ echo fi
+ touch /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/75b0878efd1a1415b470e33fb6e1da35/opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-75b0878efd1a1415b470e33fb6e1da35/etc/profile.d/.autodependencies
Processing files: lcg+root+6.41.1-75b0878efd1a1415b470e33fb6e1da35-1-1.x86_64
warning: absolute symlink: /opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-75b0878efd1a1415b470e33fb6e1da35/lib/cuda.pcm.lock -> /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/75b0878efd1a1415b470e33fb6e1da35/opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-75b0878efd1a1415b470e33fb6e1da35/lib/cuda.pcm.lock-7fad61e2
error: Symlink points to BuildRoot: /opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-75b0878efd1a1415b470e33fb6e1da35/lib/cuda.pcm.lock -> /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/75b0878efd1a1415b470e33fb6e1da35/opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-75b0878efd1a1415b470e33fb6e1da35/lib/cuda.pcm.lock-7fad61e2
RPM build warnings:
Macro expanded in comment on line 497: %{pkginstroot}/lib
Macro expanded in comment on line 498: %{pkginstroot}
|
Contributor
Author
|
please test |
Contributor
|
Pull request #10684 was updated. |
Contributor
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6587d0/54371/summary.html Failed External BuildI found compilation error when building: + echo 'test $?PY3_NUMPY_ROOT != 0 || source /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el9_amd64_gcc13/external/py3-numpy/1.26.4-6c7401133d71aa0fdd19f4799dadfbdf/etc/profile.d/init.csh'
+ echo fi
+ touch /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/168e911371bea77bf01cb4f661b198b7/opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-168e911371bea77bf01cb4f661b198b7/etc/profile.d/.autodependencies
Processing files: lcg+root+6.41.1-168e911371bea77bf01cb4f661b198b7-1-1.x86_64
warning: absolute symlink: /opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-168e911371bea77bf01cb4f661b198b7/lib/cuda.pcm.lock -> /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/168e911371bea77bf01cb4f661b198b7/opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-168e911371bea77bf01cb4f661b198b7/lib/cuda.pcm.lock-3cde3d99
error: Symlink points to BuildRoot: /opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-168e911371bea77bf01cb4f661b198b7/lib/cuda.pcm.lock -> /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/168e911371bea77bf01cb4f661b198b7/opt/cmssw/el9_amd64_gcc13/lcg/root/6.41.1-168e911371bea77bf01cb4f661b198b7/lib/cuda.pcm.lock-3cde3d99
RPM build warnings:
Macro expanded in comment on line 497: %{pkginstroot}/lib
Macro expanded in comment on line 498: %{pkginstroot}
|
Contributor
Author
|
Checking locally! |
Contributor
|
we also have seen such failures during https://github.com/cms-sw/root/pulls tests. Looks like something was merged in root master which creates a lock file and do not delete it. the lock file is a symlink pointing to a file in local build directory which rpm does not like. We need to understand what changes in root which is creating this lock file and why it isnot cleaned up after the cuda.pcm build |
9 tasks
Contributor
|
from root-project/root#21658 (comment)
Is it possible to test the hypothesis in CMSSW, by temporarily reverting that commit? My understanding of root-project/root#22683 is that it was AI-assisted... @dpiparo |
Contributor
sure , we can test the revert in cmssw |
Contributor
|
I am testing the revert of root-project/root@05b3123 via cms-sw/root#234 |
Contributor
|
@hahnjo , no, reverting the commit did not help. packaging still complins about the lock file cms-sw/root#234 (comment) ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f0423/54375/externals/root/6.41.1-ec938966552982fcf7d218e21da29e43/log ) |
Contributor
|
Hm... AFAICT the commits included on the ROOT side are root-project/root@6bf5355...adf8f9e ? |
Contributor
|
cms-sw/root#232 (comment) was run a week ago and we had seen the same error there , so I think the root commits should be between root-project/root@6bf5355...b15d1a8 . I am testing locally to see which commit caused this failure |
Contributor
|
@hahnjo , looks like problem is in root-project/root#22416 . root commit root-project/root@412ebe1 does not fail but root-project/root@4c3470e fails when we run and leave behind the lock file. |
Contributor
|
ah wait , root-project/root@17cdef8 fails too ( which is merged before root-project/root#22416 i guess) |
Contributor
Hm, isn't this contradictory: root-project/root@17cdef8 is before root-project/root@412ebe1, which you say does not fail? |
Contributor
|
my bad, I was doing inplace build for various root commits that is why results are contradictory. I did clean build of all commits and it turned out the |
Contributor
|
The Clad update was merged yesterday, while cms-sw/root#232 and cms-sw/root#233 were tested last week already... I feel we're missing something here, I'm also having a look locally. |
Contributor
|
cms-sw/root#232 also contains update to clad (cms-sw/root@2e181c5 ) and cms-sw/root#233 also contains changes for clad version. I have started cmssw tests with revert to clad via #10687 |
Contributor
|
Oh, that's what I was missing! It also explains why the results were contradictive with incremental builds, we know that version bumps are sometimes not correctly picked up (you have to kill one subdirectory manually)... |
Contributor
|
reverting clad helped and root was properly built for #10687 |
Contributor
|
@vgvassilev , building root and root/llvm in debug mode shows the following when we try to build cuda.pcm after the root build |
Contributor
|
@SahilPatidar, you have some hints I believe. |
Contributor
|
closing in favor of #10709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.