Repository navigation
Remote chats: distinguish synchronization from outages - #3
Draft
cmdr-chara wants to merge 2 commits into
Draft
cmdr-chara wants to merge 2 commits into
cmdr-chara wants to merge 2 commits into
Conversation
Integrate the implementation by @alexandre-vl from zeronsh#1038 at ca40ee6, including its regression tests and native capture fixture. This is an attributed integration, not a new independent implementation. Start from upstream's clean integration tree at 2cff845, retain the newer main changes through 962a320, and omit all fourteen PR screenshot files. Original captures are linked from the PR instead. Independent compilation, execution and fresh native screenshots remain unverified in this environment. Keep the PR in draft pending validation. Co-authored-by: Alexandre VARGAS <58216944+alexandre-vl@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Final diff review caught newer main files missing from the initial integration tree. Restore the mobile and protocol subtrees and the existing screenshots exactly to main at 962a320. The remote-sync PR must change only its thirteen source, fixture and documentation files. No remote-sync screenshot files are committed. No runtime validation is implied by this tree-level correction.
4 of 6 tasks
Owner
Author
Final integration check
Exact-head CI, fresh base/head captures and the combined integration with PRs #1 and #2 are still required. Mergeability is not a green-test result. Nothing was merged. |
7 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ca40ee678adffcc502ddbddfc214c10227a847ae, as an explicitly attributed code-only integration. The commit credits the original contributor. This is not a claim of a newly written independent implementation.remote-sync-fixture, and the original regression documentation.2cff845a91a0a643dcef82ac073628443a3fc3f5, retains all later main changes through962a3207, and omits the fourteen PR screenshot files. Images are linked below instead of committed.Before / after
These are genuine production-Shell captures published by the original contributor, comparing upstream main
c04e3749with the source implementation. They are not fresh captures from this fork's final head. The original fixture attaches the production shell to an engine and scripts delayed connectivity. Fresh base/head verification remains outstanding.Limits
A rejoin before the first successful verified write, or while writes continue to fail, can still repeat the checkpoint download. This is not a full repair for poisoned Loro documents. iOS keeps its existing grace behavior. No encryption, new network listener or direct-host transport is introduced.
Test plan
cargo nextest run --lib. The core job passed: 632 engine library tests; 1,706 tests across the selected core packages, 28 skipped; nextest also reported 3 leaky tests. Snapshot success/failure, cursor rejoin, delayed HELLO and terminal-flood regressions passed.422b9316: the combined run passed core, UI/layout and native X11/Wayland browser jobs.Capture command:
cargo run -p zeron-ui --features appshots-fixture --example remote-sync-fixture -- <output-directory> cold-open. Other scenes:revisit,outage,outage-draft,side-chat,fork. Keep capture output outside the checkout.Upstream reports 635 passing engine tests with 5 ignored, 1897 passing UI tests with two attachment tests isolated, targeted mutation failures, and a two-engine local edge check. Those are the original author's results, not tests executed in this session.
Independent verification: the earlier local builds were stopped after the laptop slowdown report. Actions are now enabled, and validation is running on GitHub-hosted runners against exact head
f44b90c8e8bba86d6a5808717636ebe527d92364:native-guijob skipped)422b9316f6d471f3c0768a32718015f6649bab49.Linux, Windows and combined Linux CI have passed. macOS/iOS CI remains queued. The native capture run completed, but visual inspection found that its head captures do not show expected changes; the base/head fork-failure images are identical. The head build appears to have reused the base build's Cargo target directory. A corrected capture run uses isolated build directories and records executable hashes; its images still need inspection, and the capture checkbox remains open. The successful Windows run does not include its optional GUI/pixel probes. No real remote host is available for the last checklist item, which remains open. This PR remains a draft. No merge is requested or performed.