Skip to content

Album Editors#11

Open
evvvritt wants to merge 5 commits intomasterfrom
ev/albums-editors
Open

Album Editors#11
evvvritt wants to merge 5 commits intomasterfrom
ev/albums-editors

Conversation

@evvvritt
Copy link
Copy Markdown

@evvvritt evvvritt commented May 5, 2020

Add Editors to Albums

  • max 4 editors per album
  • only owner can add editors
  • editors can: delete (order clovers)

details:

  • adjust error msgs
  • consistent album data response
  • PUT response: returns updated album doc
  • only emit Activity log if: name changed, clovers added

@okwme
Copy link
Copy Markdown
Member

okwme commented May 28, 2020

LGTM
What's necessary to make live @n-kort ? push to production server? this is backwards compatible right? so if we push here we don't need to push the front end at the same time or is that something we should do together?

@n-kort
Copy link
Copy Markdown
Member

n-kort commented May 29, 2020

@okwme yeah I believe a push is gonna be enough. Looks the endpoints should work even without the editors key being in the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants