Skip to content

ci: use free hosted runner for install tests - #121

Merged
Igor Rodionov (goruha) merged 3 commits into
mainfrom
osterman/finops-github-hosted-runners
Sep 18, 2026
Merged

Igor Rodionov (goruha) merged 3 commits into
mainfrom
osterman/finops-github-hosted-runners

Conversation

@osterman

@osterman Erik Osterman (Cloud Posse) (osterman) commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Move the public repository’s remaining RunsOn install job to ubuntu-latest. Standard GitHub-hosted runners are free for public repositories.

The hosted runner exposed pre-existing default-branch drift that the old RunsOn dependency cache had masked: package.json no longer matched yarn.lock, ESLint 10 was incompatible with the repository’s legacy ESLint configuration/plugins, and the checked-in dist/ bundle was stale. This PR reconciles both lockfiles, restores the compatible ESLint 8.57.1 line, and commits the reproducible Node 24 action bundle.

Validation

  • yarn --frozen-lockfile --prefer-offline
  • yarn lint:check
  • yarn format:check
  • yarn test:coverage: 63 tests pass; 96.61% line and 96.92% statement coverage
  • yarn clean && yarn build && yarn build:wrapper
  • generated dist/ verification passes
  • actionlint passes
  • no RunsOn routing labels remain in test-install.yaml

Expected savings: approximately $25–50/month.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e8218ebd-058d-45b0-8b1d-45ca601ef4ed

📥 Commits

Reviewing files that changed from the base of the PR and between cd92482 and 6091481.

⛔ Files ignored due to path filters (4)
  • dist/index.js is excluded by !**/dist/**
  • dist/wrapper/index.js is excluded by !**/dist/**
  • package-lock.json is excluded by !**/package-lock.json
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The test job now uses ubuntu-latest. The eslint development dependency is pinned to version 8.57.1 instead of 10.8.1.

Changes

Workflow runner update

Layer / File(s) Summary
Test runner configuration
.github/workflows/test-install.yaml
The test job now uses ubuntu-latest instead of the custom runner configuration.

ESLint version update

Layer / File(s) Summary
ESLint dependency configuration
package.json
The eslint development dependency is pinned to 8.57.1 instead of 10.8.1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 60914

No actionable merge-blocking risk remains in the reviewed changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly explains the runner change, related compatibility fixes, validation steps, and expected cost savings. It is directly related to the changeset.
Title check ✅ Passed The title clearly summarizes the primary change: moving install tests to a free GitHub-hosted runner. It is concise and specific.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@osterman

Copy link
Copy Markdown
Member Author

Validation note: the changed test-install.yaml job passes on ubuntu-latest, and the full integration matrix passes. The separate build check fails before build because the existing yarn.lock is inconsistent with package.json (yarn --frozen-lockfile); this PR does not modify package metadata or lockfiles.

@goruha

Copy link
Copy Markdown
Member

Co-authored-by: goruha <496956+goruha@users.noreply.github.com>

Copilot AI commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Copilot fix https://github.com/cloudposse/github-action-setup-atmos/actions/runs/35154392702/job/104990243149?pr=121

Fixed in fa8a551: restored the repo to ESLint 8.57.1, refreshed the lockfiles, and rebuilt dist/. I also validated the full CI build job locally under Node 24 (yarn --frozen-lockfile --prefer-offline, lint, format, tests, and both builds).

@osterman

Copy link
Copy Markdown
Member Author

CodeRabbit (@coderabbitai) review

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@goruha
Igor Rodionov (goruha) merged commit 9e8d1e2 into main Sep 18, 2026
18 checks passed
@goruha
Igor Rodionov (goruha) deleted the osterman/finops-github-hosted-runners branch September 18, 2026 11:55
@github-actions

Copy link
Copy Markdown

These changes were released in v3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants