feat(ui): update SignInForm default authentication error message #1811
Draft
franzheidl wants to merge 4 commits into
Draft
feat(ui): update SignInForm default authentication error message #1811franzheidl wants to merge 4 commits into
SignInForm default authentication error message #1811franzheidl wants to merge 4 commits into
Conversation
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
🦋 Changeset detectedLatest commit: 2308af4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SignInForm component in @cloudoperators/juno-ui-components to use a new default authentication error message and documents/demonstrates this behavior via Storybook and tests.
Changes:
- Updated the default
error={true}message to “Unable to authenticate the provided credentials.” - Added a Storybook story that renders the form with the default error state.
- Updated unit tests and added a changeset for the patch release.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui-components/src/components/SignInForm/SignInForm.component.tsx | Updates the default error message string and its prop documentation. |
| packages/ui-components/src/components/SignInForm/SignInForm.test.tsx | Updates assertions to match the new default error message. |
| packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx | Adds a WithError story to showcase the default error state. |
| .changeset/shiny-clowns-divide.md | Adds a patch changeset for the UI components package. |
| * Error message to display when authentication fails. | ||
| * Pass a string for a custom error message. | ||
| * Pass `true` to display the default error message "Authentication failed". | ||
| * Pass `true` to display the default error message "Unable to authenticate the provided credentials.". |
| "@cloudoperators/juno-ui-components": patch | ||
| --- | ||
|
|
||
| feat(ui): update `SignInForm` default authentication error message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the default authentication message on the
SignInFormto "Unable to authenticate the provided credentials.", and adds a story showing the default error on the form when theerrorprop is passed astrue.Screenshots
Testing Instructions
pnpm ipnpm run testChecklist
PR Manifesto
Review the PR Manifesto for best practises.