This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Shift IP Ranges#12
Open
7hunderbird wants to merge 1 commit intocloudfoundry:developfrom
7hunderbird:patch-1
Open
Shift IP Ranges#127hunderbird wants to merge 1 commit intocloudfoundry:developfrom 7hunderbird:patch-1
7hunderbird wants to merge 1 commit intocloudfoundry:developfrom
7hunderbird:patch-1
Conversation
If we increment the IP ranges from `.7`, `.8`, `.9` to `.16`, `.17`, `.18`, it will play nicer with other canonical bosh-deployment cf-deployment repositories. This is because the cf-deployment sets up a cloud-config range of `10.244.0.0/20`. That only has a usable range to `.15`: ``` $ sipcalc 10.244.0.0/20 -[ipv4 : 10.244.0.0/20] - 0 [CIDR] Host address - 10.244.0.0 Host address (decimal) - 183762944 Host address (hex) - AF40000 Network address - 10.244.0.0 Network mask - 255.255.240.0 Network mask (bits) - 20 Network mask (hex) - FFFFF000 Broadcast address - 10.244.15.255 Cisco wildcard - 0.0.15.255 Addresses in network - 4096 Network range - 10.244.0.0 - 10.244.15.255 Usable range - 10.244.0.1 - 10.244.15.254 ``` And the [convention in bosh-lite](https://bosh.io/docs/bosh-lite/) has been to add a route for internal containers to be on a `10.244.0.0/16` range. So we can get to more networks than just the cf-deployment's `/20`. I've test the `.16`, `.17`, `.18`, and all three deployments (bosh-deployment, cf-deployment, cf-mysql-deployment) work better "out of the box" with these changes.
|
Hey 7hunderbird! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Collaborator
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/160301525 The labels on this github issue will be updated when the story is started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we increment the IP ranges from
.7,.8,.9to.16,.17,.18, it will play nicer with other canonical bosh-deployment and cf-deployment repositories.This is because the cf-deployment sets up a cloud-config range of
10.244.0.0/20. That only has a usable range to.15:And the convention in bosh-lite has been to add a route for internal containers to be on a
10.244.0.0/16range. So we can get to more networks than just the cf-deployment's/20.I've tested the
.16,.17,.18, and all three deployments (bosh-deployment, cf-deployment, cf-mysql-deployment) work better "out of the box" with these changes.