Improve code quality in start command#89
Improve code quality in start command#89NickyMateev wants to merge 1 commit intocloudfoundry-attic:masterfrom
Conversation
|
❌ Hey NickyMateev! All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process. The following github user @NickyMateev is not covered by a CLA. After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s). |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/165589911 The labels on this github issue will be updated when the story is started. |
|
Hey thanks for the contribution. I definitely agree with your line of thinking here. If you get the CLA signed, we'll pull this commit right in. |
|
Hey, as an employee of SAP I know that our company has already signed the CLOUDFOUNDRY.ORG FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT (CCLA). Is there anything additional I need to do? |
|
The CLA instructions say to give the following a shot: https://help.github.com/en/articles/publicizing-or-hiding-organization-membership. And then resubmit the PR. |
|
I've actually publicized my organization membership a long time ago (it's been at least a year since I did it), so that's something I've already done. |
Improve code quality in start command
While searching in the code a little bit, I noticed a few places where there was unnecessary branching of conditional statements, which were mutually exclusive.
In my opinion the code is more clear with the proposed change.